Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 895603002: VM: Improve polymorphic check-class in optimized code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 43352)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -5746,11 +5746,9 @@
Register value = locs()->in(0).reg();
Register temp = locs()->temp(0).reg();
Label is_ok;
- intptr_t cix = 0;
- if (unary_checks().GetReceiverClassIdAt(cix) == kSmiCid) {
+ if (unary_checks().GetReceiverClassIdAt(0) == kSmiCid) {
__ testl(value, Immediate(kSmiTagMask));
__ j(ZERO, &is_ok);
- cix++; // Skip first check.
} else {
__ testl(value, Immediate(kSmiTagMask));
__ j(ZERO, deopt);
@@ -5773,11 +5771,16 @@
__ j(NOT_CARRY, deopt);
}
} else {
- const intptr_t num_checks = unary_checks().NumberOfChecks();
+ GrowableArray<CidTarget> sorted_ic_data;
+ FlowGraphCompiler::SortICDataByCount(unary_checks(),
+ &sorted_ic_data,
+ /* drop_smi = */ true);
+ const intptr_t num_checks = sorted_ic_data.length();
const bool use_near_jump = num_checks < 5;
- for (intptr_t i = cix; i < num_checks; i++) {
- ASSERT(unary_checks().GetReceiverClassIdAt(i) != kSmiCid);
- __ cmpl(temp, Immediate(unary_checks().GetReceiverClassIdAt(i)));
+ for (intptr_t i = 0; i < num_checks; i++) {
+ const intptr_t cid = sorted_ic_data[i].cid;
+ ASSERT(cid != kSmiCid);
+ __ cmpl(temp, Immediate(cid));
if (i == (num_checks - 1)) {
__ j(NOT_EQUAL, deopt);
} else {
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698