Update yield warnings.

Update yield warnings.

BUG=http://dartbug.com/22260
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43500

[Johnni Winther, 2015-02-04 10:38:14]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-02-04 15:44:58]

LGTM.

https://codereview.chromium.org/895583006/diff/20001/pkg/compiler/lib/src/cor...
File pkg/compiler/lib/src/core_types.dart (right):

https://codereview.chromium.org/895583006/diff/20001/pkg/compiler/lib/src/cor...
pkg/compiler/lib/src/core_types.dart:44: /// Returns an instance of the `List`
type defined in 'dart:core' with
of the `Iterable` type defined in...

https://codereview.chromium.org/895583006/diff/20001/pkg/compiler/lib/src/cor...
pkg/compiler/lib/src/core_types.dart:48: /// Returns an instance of the `List`
type defined in 'dart:async' with
Future type.

https://codereview.chromium.org/895583006/diff/20001/pkg/compiler/lib/src/res...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/895583006/diff/20001/pkg/compiler/lib/src/res...
pkg/compiler/lib/src/resolution/members.dart:2482: inFunctionDeclaration ?
AsyncMarker.SYNC : function.asyncMarker);
What does 'inFunctionDeclaration' do?
Why does it override the function's async-marker?

[Johnni Winther, 2015-02-05 08:41:20]

New patchsets have been uploaded after l-g-t-m from floitsch@google.com

[Johnni Winther, 2015-02-05 08:48:32]

https://codereview.chromium.org/895583006/diff/20001/pkg/compiler/lib/src/cor...
File pkg/compiler/lib/src/core_types.dart (right):

https://codereview.chromium.org/895583006/diff/20001/pkg/compiler/lib/src/cor...
pkg/compiler/lib/src/core_types.dart:44: /// Returns an instance of the `List`
type defined in 'dart:core' with
On 2015/02/04 15:44:57, floitsch wrote:
> of the `Iterable` type defined in...

Done.

https://codereview.chromium.org/895583006/diff/20001/pkg/compiler/lib/src/cor...
pkg/compiler/lib/src/core_types.dart:48: /// Returns an instance of the `List`
type defined in 'dart:async' with
On 2015/02/04 15:44:57, floitsch wrote:
> Future type.

Done.

https://codereview.chromium.org/895583006/diff/20001/pkg/compiler/lib/src/res...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/895583006/diff/20001/pkg/compiler/lib/src/res...
pkg/compiler/lib/src/resolution/members.dart:2482: inFunctionDeclaration ?
AsyncMarker.SYNC : function.asyncMarker);
On 2015/02/04 15:44:57, floitsch wrote:
> What does 'inFunctionDeclaration' do?
> Why does it override the function's async-marker?

[inFunctionDeclaration] is `true` if [function] is a location function
declaration and not (anonymous) function expression. Only in the should the
return type be determined using the async marker.

Have refactored to code to put the logic for the later fully in
SignatureResolver.

[Johnni Winther, 2015-02-05 08:48:47]

PTAL @ the last patch

[floitsch, 2015-02-05 11:07:30]

Still LGTM.

[Johnni Winther, 2015-02-05 11:39:28]

Committed patchset #3 (id:40001) manually as 43500 (presubmit successful).