Update yield warnings.

pkg/compiler/lib/src/resolution/members.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of resolution;
 
 abstract class TreeElements {
   AnalyzableElement get analyzedElement;
   Iterable<Node> get superUses;
 
@@ skipping 2452 matching lines @@
     visit(node.returnType);
     String name;
     if (node.name == null) {
       name = "";
     } else {
       name = node.name.asIdentifier().source;
     }
     LocalFunctionElementX function = new LocalFunctionElementX(
         name, node, ElementKind.FUNCTION, Modifiers.EMPTY,
         enclosingElement);
-    function.functionSignatureCache =
-        SignatureResolver.analyze(compiler, node.parameters, node.returnType,
-            function, registry, createRealParameters: true);
     ResolverTask.processAsyncMarker(compiler, function);
+    function.functionSignatureCache = SignatureResolver.analyze(
+        compiler,
+        node.parameters,
+        node.returnType,
+        function,
+        registry,
+        createRealParameters: true,
+        asyncMarker:
+            inFunctionDeclaration ? AsyncMarker.SYNC : function.asyncMarker);

[floitsch, 2015/02/04 15:44:57]

What does 'inFunctionDeclaration' do?
Why does it override the function's async-marker?

[Johnni Winther, 2015/02/05 08:48:32]

[inFunctionDeclaration] is `true` if [function] is a location function
declaration and not (anonymous) function expression. Only in the should the
return type be determined using the async marker.

Have refactored to code to put the logic for the later fully in
SignatureResolver.

     checkLocalDefinitionName(node, function);
     registry.defineFunction(node, function);
     if (doAddToScope) {
       addToScope(function);
     }
     Scope oldScope = scope; // The scope is modified by [setupFunction].
     setupFunction(node, function);
 
     Element previousEnclosingElement = enclosingElement;
     enclosingElement = function;
@@ skipping 2539 matching lines @@
 }
 
 /// The result for the resolution of the `assert` method.
 class AssertResult implements ResolutionResult {
   const AssertResult();
 
   Element get element => null;
 
   String toString() => 'AssertResult()';
 }