Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 895093002: Add getClassList RPC (Closed)

Created:
5 years, 10 months ago by Cutch
Modified:
5 years, 10 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add getClassList RPC BUG= Committed: https://code.google.com/p/dart/source/detail?r=43414

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -882 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/observatory/test/classes_test.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/class_table.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/service.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M runtime/vm/service/service.idl View 1 2 5 chunks +19 lines, -2 lines 0 comments Download
D tests/standalone/vmservice/field_script.dart View 1 1 chunk +0 lines, -41 lines 0 comments Download
D tests/standalone/vmservice/isolate_bad_class_test.dart View 1 1 chunk +0 lines, -57 lines 0 comments Download
D tests/standalone/vmservice/isolate_bad_object_test.dart View 1 1 chunk +0 lines, -57 lines 0 comments Download
D tests/standalone/vmservice/isolate_class_field_test.dart View 1 1 chunk +0 lines, -180 lines 0 comments Download
D tests/standalone/vmservice/isolate_echo_script.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D tests/standalone/vmservice/isolate_echo_test.dart View 1 1 chunk +0 lines, -59 lines 0 comments Download
D tests/standalone/vmservice/isolate_list_script.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D tests/standalone/vmservice/isolate_list_test.dart View 1 1 chunk +0 lines, -29 lines 0 comments Download
D tests/standalone/vmservice/multiple_isolate_list_script.dart View 1 1 chunk +0 lines, -25 lines 0 comments Download
D tests/standalone/vmservice/multiple_isolate_list_test.dart View 1 1 chunk +0 lines, -27 lines 0 comments Download
D tests/standalone/vmservice/test_helper.dart View 1 1 chunk +0 lines, -274 lines 0 comments Download
D tests/standalone/vmservice/unknown_command_script.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D tests/standalone/vmservice/unknown_command_test.dart View 1 1 chunk +0 lines, -26 lines 0 comments Download
D tests/standalone/vmservice/unknown_isolate_command_script.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D tests/standalone/vmservice/unknown_isolate_command_test.dart View 1 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Cutch
5 years, 10 months ago (2015-02-03 17:35:30 UTC) #2
turnidge
As discussed offline... Update runtime/service/service.idl. Add a test. https://codereview.chromium.org/895093002/diff/1/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/895093002/diff/1/runtime/observatory/lib/src/service/object.dart#newcode839 runtime/observatory/lib/src/service/object.dart:839: _loadClasses).then(_buildClassHierarchy); ...
5 years, 10 months ago (2015-02-03 17:39:30 UTC) #3
Cutch
Updated service.idl and added a test. https://codereview.chromium.org/895093002/diff/1/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/895093002/diff/1/runtime/observatory/lib/src/service/object.dart#newcode839 runtime/observatory/lib/src/service/object.dart:839: _loadClasses).then(_buildClassHierarchy); On 2015/02/03 ...
5 years, 10 months ago (2015-02-03 17:54:30 UTC) #4
turnidge
LGTMwC https://codereview.chromium.org/895093002/diff/20001/runtime/vm/service/service.idl File runtime/vm/service/service.idl (right): https://codereview.chromium.org/895093002/diff/20001/runtime/vm/service/service.idl#newcode288 runtime/vm/service/service.idl:288: classes []Class Class -> ClassRef
5 years, 10 months ago (2015-02-03 17:59:09 UTC) #5
Cutch
https://codereview.chromium.org/895093002/diff/20001/runtime/vm/service/service.idl File runtime/vm/service/service.idl (right): https://codereview.chromium.org/895093002/diff/20001/runtime/vm/service/service.idl#newcode288 runtime/vm/service/service.idl:288: classes []Class On 2015/02/03 17:59:09, turnidge wrote: > Class ...
5 years, 10 months ago (2015-02-03 17:59:56 UTC) #6
Cutch
5 years, 10 months ago (2015-02-03 18:00:02 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 43414 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698