Refactor handling of source map information.

Refactor handling of source map information.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43595

[Johnni Winther, 2015-02-06 09:47:12]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[Johnni Winther, 2015-02-09 12:51:46]

Ping.

[floitsch, 2015-02-09 13:16:22]

LGTM.

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
File pkg/compiler/lib/src/io/source_information.dart (right):

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:7: import '../dart2jslib.dart'
show SourceSpan;
This file seems to be a copy of another source.
I realized that too late. In this CL, don't modify the sources (just move/copy
them).
Take my comments as requests for changes in a future CL.

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:17: abstract class
SourceInformation {
comments.

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:23: class
StartEndSourceInformation implements SourceInformation {
comments.

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:50: endPosition.hashCode * 19;
& 0x7FFFFFFF

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:67: // TODO(sra): Attaching
positions might be cleaner if the source position
Is this comment still relevant?
I don't understand it.

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:118: int getLine() {
maybe add TODOs, to refactor this code? (unless you are already on it).
line -> _line;
int getLine() => int get line;
...

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/js/node...
File pkg/compiler/lib/src/js/nodes.dart (right):

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/js/node...
pkg/compiler/lib/src/js/nodes.dart:201: //Node withLocation(var sourcePosition)
=>
Remove?

[Johnni Winther, 2015-02-09 14:50:10]

New patchsets have been uploaded after l-g-t-m from floitsch@google.com

[Johnni Winther, 2015-02-09 14:58:36]

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
File pkg/compiler/lib/src/io/source_information.dart (right):

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:7: import '../dart2jslib.dart'
show SourceSpan;
On 2015/02/09 13:16:22, floitsch wrote:
> This file seems to be a copy of another source.
> I realized that too late. In this CL, don't modify the sources (just move/copy
> them).
> Take my comments as requests for changes in a future CL.

50% is moved, but from several places.

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:17: abstract class
SourceInformation {
On 2015/02/09 13:16:22, floitsch wrote:
> comments.

Done.

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:23: class
StartEndSourceInformation implements SourceInformation {
On 2015/02/09 13:16:22, floitsch wrote:
> comments.

Done.

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:50: endPosition.hashCode * 19;
On 2015/02/09 13:16:22, floitsch wrote:
> & 0x7FFFFFFF

Done.

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:67: // TODO(sra): Attaching
positions might be cleaner if the source position
On 2015/02/09 13:16:22, floitsch wrote:
> Is this comment still relevant?
> I don't understand it.

Removed. I'm taking a different route.

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_information.dart:118: int getLine() {
On 2015/02/09 13:16:22, floitsch wrote:
> maybe add TODOs, to refactor this code? (unless you are already on it).
> line -> _line;
> int getLine() => int get line;
> ...

Done.

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/js/node...
File pkg/compiler/lib/src/js/nodes.dart (right):

https://codereview.chromium.org/893963005/diff/1/pkg/compiler/lib/src/js/node...
pkg/compiler/lib/src/js/nodes.dart:201: //Node withLocation(var sourcePosition)
=>
On 2015/02/09 13:16:22, floitsch wrote:
> Remove?

Done.

[Johnni Winther, 2015-02-09 15:05:05]

Committed patchset #2 (id:20001) manually as 43595 (presubmit successful).