pkg/compiler/lib/src/ssa/codegen_helpers.dart - Issue 893963005: Refactor handling of source map information.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/codegen_helpers.dart

Issue 893963005: Refactor handling of source map information. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/codegen_helpers.dart

diff --git a/pkg/compiler/lib/src/ssa/codegen_helpers.dart b/pkg/compiler/lib/src/ssa/codegen_helpers.dart

index 88e5505d6b21c942c24a1c4e2770cbbe9ec63970..c298e06bc32dbce718a3418bbf9c026f97daf853 100644

--- a/pkg/compiler/lib/src/ssa/codegen_helpers.dart

+++ b/pkg/compiler/lib/src/ssa/codegen_helpers.dart

@@ -34,8 +34,8 @@ class SsaInstructionSelection extends HBaseVisitor {

if (replacement.sourceElement == null) {

replacement.sourceElement = instruction.sourceElement;

}

- if (replacement.sourcePosition == null) {

- replacement.sourcePosition = instruction.sourcePosition;

+ if (replacement.sourceInformation == null) {

+ replacement.sourceInformation = instruction.sourceInformation;

}

if (!replacement.isInBasicBlock()) {

// The constant folding can return an instruction that is already