Add an option for starting a detached process with stdio connected

Add an option for starting a detached process with stdio connected

R=lrn@google.com, kustermann@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43393

[Søren Gjesse, 2015-01-30 11:57:34]

Process.start now has three modes:

/// Normal child process.
NORMAL,
/// Detached child process.
DETACHED,
/// Detachad clild process with stdin, stdout and stderr connected.
DETACHED_WITH_STDIO

instead of the detach flag. The documentation in process.dart should explain.

This also contains some refactoring of the Windows code. There will be more
Windows refactoring in a separate CL.

[Lasse Reichstein Nielsen, 2015-01-30 12:11:37]

lgtm

Are we testing DETACHED_WITH_STDIO?

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:110: /// Detachad clild process with stdin, stdout and
stderr connected.
clild -> child
Connected to what?

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:263: * resources will not be freed since there is still
pending data.
freed -> released

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:274: * will be started.
Explain what "normal" means, or rephrase as:

If [mode] is not [ProcessStartMode.NORMAL], some features of [Process] may be
unavailable.

... then the following explains which features are missing for the other modes.

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:280: * is no connection to its `stdin`, `stdout` or
`stderr` nor will
comma before "nor"?

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:285: * are connected. The creator can communication with
the child. When
can communication with the child -> 
can communicate with the child through these.

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:286: * these communication channels are closed the
detached process will
Rewrite as: The detached process will keep running even if these communication
channels are closed.

Is this different from a NORMAL process? If not, no need to write it. If so, say
that a normal process will stop if the input/output is closed.

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:287: * keep running. Its exit code will not become
available when it
Its -> The process'

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:288: * terminated.
terminated -> terminates.

[Søren Gjesse, 2015-02-02 13:56:45]

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:110: /// Detachad clild process with stdin, stdout and
stderr connected.
On 2015/01/30 12:11:37, Lasse Reichstein Nielsen wrote:
> clild -> child
> Connected to what?

Done.

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:263: * resources will not be freed since there is still
pending data.
On 2015/01/30 12:11:37, Lasse Reichstein Nielsen wrote:
> freed -> released

Done.

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:274: * will be started.
On 2015/01/30 12:11:37, Lasse Reichstein Nielsen wrote:
> Explain what "normal" means, or rephrase as:
> 
> If [mode] is not [ProcessStartMode.NORMAL], some features of [Process] may be
> unavailable.
> 
> ... then the following explains which features are missing for the other
modes.

Done.

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:280: * is no connection to its `stdin`, `stdout` or
`stderr` nor will
On 2015/01/30 12:11:37, Lasse Reichstein Nielsen wrote:
> comma before "nor"?

Done.

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:285: * are connected. The creator can communication with
the child. When
On 2015/01/30 12:11:37, Lasse Reichstein Nielsen wrote:
> can communication with the child -> 
> can communicate with the child through these.

Done.

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:286: * these communication channels are closed the
detached process will
On 2015/01/30 12:11:37, Lasse Reichstein Nielsen wrote:
> Rewrite as: The detached process will keep running even if these communication
> channels are closed.
> 
> Is this different from a NORMAL process? If not, no need to write it. If so,
say
> that a normal process will stop if the input/output is closed.

Done.

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:287: * keep running. Its exit code will not become
available when it
On 2015/01/30 12:11:37, Lasse Reichstein Nielsen wrote:
> Its -> The process'

Done.

https://codereview.chromium.org/890633002/diff/40001/sdk/lib/io/process.dart#...
sdk/lib/io/process.dart:288: * terminated.
On 2015/01/30 12:11:37, Lasse Reichstein Nielsen wrote:
> terminated -> terminates.

Done.

[Søren Gjesse, 2015-02-03 13:38:52]

Committed patchset #7 (id:120001) manually as 43393 (presubmit successful).