Add an option for starting a detached process with stdio connected

runtime/bin/process.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dartutils.h"
 #include "bin/io_buffer.h"
 #include "bin/platform.h"
 #include "bin/process.h"
 #include "bin/socket.h"
 #include "bin/utils.h"
@@ skipping 100 matching lines @@
         ExtractCStringList(environment,
                            status_handle,
                            "Environment values must be builtin strings",
                            &environment_length);
     if (string_environment == NULL) {
       delete[] string_args;
       Dart_SetReturnValue(args, Dart_NewBoolean(false));
       return;
     }
   }
-  bool detached = DartUtils::GetBooleanValue(Dart_GetNativeArgument(args, 5));
+  int64_t mode =
+      DartUtils::GetInt64ValueCheckRange(Dart_GetNativeArgument(args, 5), 0, 2);
   Dart_Handle stdin_handle = Dart_GetNativeArgument(args, 6);
   Dart_Handle stdout_handle = Dart_GetNativeArgument(args, 7);
   Dart_Handle stderr_handle = Dart_GetNativeArgument(args, 8);
   Dart_Handle exit_handle = Dart_GetNativeArgument(args, 9);
   intptr_t pid = -1;
   char* os_error_message = NULL;
 
   int error_code = Process::Start(path,
                                   string_args,
                                   args_length,
                                   working_directory,
                                   string_environment,
                                   environment_length,
-                                  detached,
+                                  static_cast<ProcessStartMode>(mode),
                                   &process_stdout,
                                   &process_stdin,
                                   &process_stderr,
                                   &pid,
                                   &exit_event,
                                   &os_error_message);
   if (error_code == 0) {
-    if (!detached) {
+    if (mode != kDetached) {
       Socket::SetSocketIdNativeField(stdin_handle, process_stdin);
       Socket::SetSocketIdNativeField(stdout_handle, process_stdout);
       Socket::SetSocketIdNativeField(stderr_handle, process_stderr);
+    }
+    if (mode == kNormal) {
       Socket::SetSocketIdNativeField(exit_handle, exit_event);
     }
     Process::SetProcessIdNativeField(process, pid);
   } else {
     DartUtils::SetIntegerField(
         status_handle, "_errorCode", error_code);
     DartUtils::SetStringField(
         status_handle,
         "_errorMessage",
         os_error_message != NULL ? os_error_message
@@ skipping 154 matching lines @@
   int external_length = strlen(system_string);
   uint8_t* buffer = NULL;
   Dart_Handle external_array = IOBuffer::Allocate(external_length, &buffer);
   memmove(buffer, system_string, external_length);
   if (utf8 != system_string) free(const_cast<char*>(system_string));
   Dart_SetReturnValue(args, external_array);
 }
 
 }  // namespace bin
 }  // namespace dart