Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 890443003: Revert "dart2js: remove invalid case in generateParameterStubStatements in NativeEmitter." (Closed)

Created:
5 years, 10 months ago by zarah
Modified:
5 years, 10 months ago
Reviewers:
floitsch, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "dart2js: remove invalid case in generateParameterStubStatements in NativeEmitter." Added comment. This reverts commit r43282. Committed: https://code.google.com/p/dart/source/detail?r=43285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zarah
TBR
5 years, 10 months ago (2015-01-29 14:31:39 UTC) #2
zarah
Committed patchset #1 (id:1) manually as 43285 (presubmit successful).
5 years, 10 months ago (2015-01-29 14:32:34 UTC) #3
floitsch
5 years, 10 months ago (2015-01-29 14:40:04 UTC) #4
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698