Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: pkg/compiler/lib/src/js_emitter/native_emitter.dart

Issue 890443003: Revert "dart2js: remove invalid case in generateParameterStubStatements in NativeEmitter." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/native_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/native_emitter.dart b/pkg/compiler/lib/src/js_emitter/native_emitter.dart
index d4e1fe434be0f4fa0c66269f7a63de1297d0f1c8..ecde8235c070742f62bd75f0c2f30579c1b7e16b 100644
--- a/pkg/compiler/lib/src/js_emitter/native_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/native_emitter.dart
@@ -333,10 +333,17 @@ class NativeEmitter {
// arguments up until the last one provided.
target = member.fixedBackendName;
- assert(invariant(member, isInterceptedMethod));
- receiver = argumentsBuffer[0];
- arguments = argumentsBuffer.sublist(1,
- indexOfLastOptionalArgumentInParameters + 1);
+ if (isInterceptedMethod) {
+ receiver = argumentsBuffer[0];
+ arguments = argumentsBuffer.sublist(1,
+ indexOfLastOptionalArgumentInParameters + 1);
+ } else {
+ // Native methods that are not intercepted must be static.
+ assert(invariant(member, member.isStatic));
+ receiver = js('this');
+ arguments = argumentsBuffer.sublist(0,
+ indexOfLastOptionalArgumentInParameters + 1);
+ }
statements.add(
js.statement('return #.#(#)', [receiver, target, arguments]));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698