Don't crash 'pub get' if a dev dependency is broken.

Don't crash 'pub get' if a dev dependency is broken.

We were validating that the dependencies and dev_dependencies had no overlap
whenever we accessed [Pubspec.dependencies], but this meant that we had to parse
the dev_dependencies even if they were going unused. If that parse failed, it
could stop an entire "pub get" from working. Now we only do this validation when
[Pubspec.devDependencies] is accessed.

This also fixes a bug in where, if a pubspec from outside the filesystem (e.g. a
hosted dependency) has a relative path dependency, [PathSource.parseDescription]
would crash. Although this shouldn't happen since we don't parse the dev
dependencies anymore, [PathSource] will now handle it more gracefully if it
does.

Finally, this also works around an async_await bug that was causing stack traces
to be truncated.

R=rnystrom@google.com
BUG=22194
Committed: https://code.google.com/p/dart/source/detail?r=43267

[Bob Nystrom, 2015-01-28 23:42:00]

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/pubspec.dart:107:
_checkDependencyOverlap(dependencies, _devDependencies);
What do you think about calling this from both dependencies and devDependencies
but passing in _dependencies and _devDependencies and returning if either is
null? In other words, you only validate overlaps if both sets get accessed?

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/pubspec.dart:491: return desc;
Temp code, I assume.

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/test/g...
File
sdk/lib/_internal/pub/test/get/hosted/gets_a_package_with_busted_dev_dependencies_test.dart
(right):

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/test/g...
sdk/lib/_internal/pub/test/get/hosted/gets_a_package_with_busted_dev_dependencies_test.dart:15:
integration('gets a package with broken dev dependencies from a pub server',
"package" -> "dependency".

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/test/p...
File sdk/lib/_internal/pub/test/pubspec_test.dart (right):

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/test/p...
sdk/lib/_internal/pub/test/pubspec_test.dart:394: // It's important that this
not be parsed, so that it doesn't
Delete?

[nweiz, 2015-01-29 01:13:57]

Code review changes

[nweiz, 2015-01-29 01:23:05]

Code review changes

[nweiz, 2015-01-29 01:26:22]

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/pubspec.dart:107:
_checkDependencyOverlap(dependencies, _devDependencies);
On 2015/01/28 23:42:00, Bob Nystrom wrote:
> What do you think about calling this from both dependencies and
devDependencies
> but passing in _dependencies and _devDependencies and returning if either is
> null? In other words, you only validate overlaps if both sets get accessed?

Done.

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/pubspec.dart:491: return desc;
On 2015/01/28 23:42:00, Bob Nystrom wrote:
> Temp code, I assume.

Done.

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/test/g...
File
sdk/lib/_internal/pub/test/get/hosted/gets_a_package_with_busted_dev_dependencies_test.dart
(right):

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/test/g...
sdk/lib/_internal/pub/test/get/hosted/gets_a_package_with_busted_dev_dependencies_test.dart:15:
integration('gets a package with broken dev dependencies from a pub server',
On 2015/01/28 23:42:00, Bob Nystrom wrote:
> "package" -> "dependency".

Done.

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/test/p...
File sdk/lib/_internal/pub/test/pubspec_test.dart (right):

https://codereview.chromium.org/887483002/diff/1/sdk/lib/_internal/pub/test/p...
sdk/lib/_internal/pub/test/pubspec_test.dart:394: // It's important that this
not be parsed, so that it doesn't
On 2015/01/28 23:42:00, Bob Nystrom wrote:
> Delete?

Done.

[Bob Nystrom, 2015-01-29 01:33:33]

lgtm

[nweiz, 2015-01-29 01:38:22]

Committed patchset #3 (id:40001) manually as 43267 (presubmit successful).