Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: sdk/lib/_internal/pub/test/get/hosted/gets_a_package_with_busted_dev_dependencies_test.dart

Issue 887483002: Don't crash 'pub get' if a dev dependency is broken. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/source/path.dart ('k') | sdk/lib/_internal/pub/test/pubspec_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/get/hosted/gets_a_package_with_busted_dev_dependencies_test.dart
diff --git a/sdk/lib/_internal/pub/test/get/hosted/get_test.dart b/sdk/lib/_internal/pub/test/get/hosted/gets_a_package_with_busted_dev_dependencies_test.dart
similarity index 50%
copy from sdk/lib/_internal/pub/test/get/hosted/get_test.dart
copy to sdk/lib/_internal/pub/test/get/hosted/gets_a_package_with_busted_dev_dependencies_test.dart
index 58890c818377599f3a60f623bfa8f7797e6b0057..2b8f2bfff39b8deeab857087f1f500799cbf07a3 100644
--- a/sdk/lib/_internal/pub/test/get/hosted/get_test.dart
+++ b/sdk/lib/_internal/pub/test/get/hosted/gets_a_package_with_busted_dev_dependencies_test.dart
@@ -1,4 +1,4 @@
-// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -10,8 +10,17 @@ import '../../test_pub.dart';
main() {
initConfig();
- integration('gets a package from a pub server', () {
- servePackages((builder) => builder.serve("foo", "1.2.3"));
+
+ // Regression test for issue 22194.
+ integration('gets a dependency with broken dev dependencies from a pub '
+ 'server', () {
+ servePackages((builder) {
+ builder.serve("foo", "1.2.3", pubspec: {
+ "dev_dependencies": {
+ "busted": {"not a real source": null}
+ }
+ });
+ });
d.appDir({"foo": "1.2.3"}).create();
@@ -20,15 +29,4 @@ main() {
d.cacheDir({"foo": "1.2.3"}).validate();
d.packagesDir({"foo": "1.2.3"}).validate();
});
-
- integration('URL encodes the package name', () {
- serveNoPackages();
-
- d.appDir({"bad name!": "1.2.3"}).create();
-
- pubGet(
- error: new RegExp(
- r"Could not find package bad name! at http://localhost:\d+\."),
- exitCode: exit_codes.UNAVAILABLE);
- });
}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/source/path.dart ('k') | sdk/lib/_internal/pub/test/pubspec_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698