Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 887413003: Port type arguments to new RPC protocol (Closed)

Created:
5 years, 10 months ago by Cutch
Modified:
5 years, 10 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Port type arguments to new RPC protocol R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=43428

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -76 lines) Patch
M runtime/bin/bin.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A runtime/observatory/test/type_arguments_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service.cc View 6 chunks +53 lines, -53 lines 0 comments Download
M runtime/vm/service/message.dart View 1 3 chunks +21 lines, -4 lines 0 comments Download
M runtime/vm/service/service.idl View 1 4 chunks +23 lines, -0 lines 0 comments Download
M runtime/vm/service_test.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
5 years, 10 months ago (2015-02-03 21:00:29 UTC) #2
turnidge
lgtm w/ c https://codereview.chromium.org/887413003/diff/1/runtime/vm/service/message.dart File runtime/vm/service/message.dart (right): https://codereview.chromium.org/887413003/diff/1/runtime/vm/service/message.dart#newcode64 runtime/vm/service/message.dart:64: Comment about why https://codereview.chromium.org/887413003/diff/1/runtime/vm/service/service.idl File runtime/vm/service/service.idl ...
5 years, 10 months ago (2015-02-03 21:09:35 UTC) #3
Cutch
Committed patchset #2 (id:20001) manually as 43428 (presubmit successful).
5 years, 10 months ago (2015-02-03 21:26:31 UTC) #5
Cutch
5 years, 10 months ago (2015-02-03 21:35:53 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/887413003/diff/1/runtime/vm/service/message.dart
File runtime/vm/service/message.dart (right):

https://codereview.chromium.org/887413003/diff/1/runtime/vm/service/message.d...
runtime/vm/service/message.dart:64: 
On 2015/02/03 21:09:35, turnidge wrote:
> Comment about why

Done.

https://codereview.chromium.org/887413003/diff/1/runtime/vm/service/service.idl
File runtime/vm/service/service.idl (right):

https://codereview.chromium.org/887413003/diff/1/runtime/vm/service/service.i...
runtime/vm/service/service.idl:80: // with instantiations. Otherwise, all type
arguments are returned.
On 2015/02/03 21:09:35, turnidge wrote:
> I've been using <code/> around argument names.  Not sure if that is really
what
> we want but should do it for consistency.

Done.

Powered by Google App Engine
This is Rietveld 408576698