Port type arguments to new RPC protocol

runtime/vm/service/message.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of vmservice;
 
 class Message {
   final Completer _completer = new Completer.sync();
   bool get completed => _completer.isCompleted;
   /// Future of response.
@@ skipping 44 matching lines @@
     }
   }
 
   dynamic toJson() {
     return {
       'path': path,
       'params': params
     };
   }
 
+  // Calls toString on all non-String elements of [list]. We do this so all
+  // elements in the list are strings, making consumption by C++ simpler.
+  // This has a side effect that boolean literal values like true become 'true'
+  // and thus indistinguishable from the string literal 'true'.
+  List _makeAllString(List list) {
+    if (list == null) {
+      return null;
+    }
+    for (var i = 0; i < list.length; i++) {
+      if (list[i] is String) {
+        continue;
+      }
+      list[i] = list[i].toString();
+    }
+    return list;
+  }
+
   Future<String> send(SendPort sendPort) {
     final receivePort = new RawReceivePort();
     receivePort.handler = (value) {
       receivePort.close();
       if (value is Exception) {
         _completer.completeError(value);
       } else {
         _completer.complete(value);
       }
     };
-    var keys = params.keys.toList(growable:false);
-    var values = params.values.toList(growable:false);
+    var keys = _makeAllString(params.keys.toList(growable:false));
+    var values = _makeAllString(params.values.toList(growable:false));
     var request = new List(5)
         ..[0] = 0  // Make room for OOB message type.
         ..[1] = receivePort.sendPort
         ..[2] = (isOld ? path : method)
         ..[3] = keys
         ..[4] = values;
     sendIsolateServiceMessage(sendPort, request);
     return _completer.future;
   }
 
   Future<String> sendToVM() {
     final receivePort = new RawReceivePort();
     receivePort.handler = (value) {
       receivePort.close();
       if (value is Exception) {
         _completer.completeError(value);
       } else {
         _completer.complete(value);
       }
     };
-    var keys = params.keys.toList(growable:false);
-    var values = params.values.toList(growable:false);
+    var keys = _makeAllString(params.keys.toList(growable:false));
+    var values = _makeAllString(params.values.toList(growable:false));
     var request = new List(5)
         ..[0] = 0  // Make room for OOB message type.
         ..[1] = receivePort.sendPort
         ..[2] = (isOld ? path : method)
         ..[3] = keys
         ..[4] = values;
     sendRootServiceMessage(request);
     return _completer.future;
   }
 
@@ skipping 11 matching lines @@
         'params': params
     }));
   }
 }
 
 void sendIsolateServiceMessage(SendPort sp, List m)
     native "VMService_SendIsolateServiceMessage";
 
 void sendRootServiceMessage(List m)
     native "VMService_SendRootServiceMessage";