Fix await parsing.

Fix await parsing.

BUG=http://dartbug.com/22183
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43398

[Johnni Winther, 2015-02-03 13:23:35]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-02-03 13:34:21]

LGTM.

https://codereview.chromium.org/886833005/diff/40001/pkg/compiler/lib/src/typ...
File pkg/compiler/lib/src/typechecker.dart (right):

https://codereview.chromium.org/886833005/diff/40001/pkg/compiler/lib/src/typ...
pkg/compiler/lib/src/typechecker.dart:1604: DartType flatten(DartType type) {
add comment.

https://codereview.chromium.org/886833005/diff/40001/pkg/compiler/lib/src/typ...
pkg/compiler/lib/src/typechecker.dart:1604: DartType flatten(DartType type) {
This seems to be very await specific (talking about 'future'). rename function?

https://codereview.chromium.org/886833005/diff/40001/pkg/compiler/lib/src/typ...
pkg/compiler/lib/src/typechecker.dart:1604: DartType flatten(DartType type) {
If I understand correctly this reduces the type of Future<Future<Future<int>>>
to int. I'm not sure how much this makes sense. A Future<Future<int>> will have
a dynamic error, since its T will never match the correct runtime type (which
would be 'int').

https://codereview.chromium.org/886833005/diff/40001/tests/compiler/dart2js/m...
File tests/compiler/dart2js/mock_libraries.dart (right):

https://codereview.chromium.org/886833005/diff/40001/tests/compiler/dart2js/m...
tests/compiler/dart2js/mock_libraries.dart:366: 'DeferredLibrary': 'class
DeferredLibrary {}',
?
I didn't even know that DeferredLibrary still existed...

[Johnni Winther, 2015-02-03 14:12:56]

https://codereview.chromium.org/886833005/diff/40001/pkg/compiler/lib/src/typ...
File pkg/compiler/lib/src/typechecker.dart (right):

https://codereview.chromium.org/886833005/diff/40001/pkg/compiler/lib/src/typ...
pkg/compiler/lib/src/typechecker.dart:1604: DartType flatten(DartType type) {
On 2015/02/03 13:34:21, floitsch wrote:
> This seems to be very await specific (talking about 'future'). rename
function?

It term 'flatten' is from the spec is used to describe the static typing of
await and type checking of return (no implemented yet).

https://codereview.chromium.org/886833005/diff/40001/pkg/compiler/lib/src/typ...
pkg/compiler/lib/src/typechecker.dart:1604: DartType flatten(DartType type) {
On 2015/02/03 13:34:21, floitsch wrote:
> add comment.

Done.

https://codereview.chromium.org/886833005/diff/40001/tests/compiler/dart2js/m...
File tests/compiler/dart2js/mock_libraries.dart (right):

https://codereview.chromium.org/886833005/diff/40001/tests/compiler/dart2js/m...
tests/compiler/dart2js/mock_libraries.dart:366: 'DeferredLibrary': 'class
DeferredLibrary {}',
On 2015/02/03 13:34:21, floitsch wrote:
> ?
> I didn't even know that DeferredLibrary still existed...

I _is_ deprecated to be removed in 1.8...

[Johnni Winther, 2015-02-03 14:14:48]

https://codereview.chromium.org/886833005/diff/40001/tests/compiler/dart2js/m...
File tests/compiler/dart2js/mock_libraries.dart (right):

https://codereview.chromium.org/886833005/diff/40001/tests/compiler/dart2js/m...
tests/compiler/dart2js/mock_libraries.dart:366: 'DeferredLibrary': 'class
DeferredLibrary {}',
On 2015/02/03 14:12:56, Johnni Winther wrote:
> On 2015/02/03 13:34:21, floitsch wrote:
> > ?
> > I didn't even know that DeferredLibrary still existed...
> 
> I _is_ deprecated to be removed in 1.8...

That should be 'It _is_' - and not 'I _am_' ;-)

[Johnni Winther, 2015-02-03 14:21:26]

Committed patchset #4 (id:60001) manually as 43398 (presubmit successful).