Fix await parsing.

pkg/compiler/lib/src/typechecker.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 class TypeCheckerTask extends CompilerTask {
   TypeCheckerTask(Compiler compiler) : super(compiler);
   String get name => "Type checker";
 
@@ skipping 1583 matching lines @@
     }
     return const StatementType();
   }
 
   DartType visitThrow(Throw node) {
     // TODO(johnniwinther): Handle reachability.
     analyze(node.expression);
     return const DynamicType();
   }
 
+  DartType flatten(DartType type) {

[floitsch, 2015/02/03 13:34:21]

add comment.

[floitsch, 2015/02/03 13:34:21]

If I understand correctly this reduces the type of Future<Future<Future<int>>>
to int. I'm not sure how much this makes sense. A Future<Future<int>> will have
a dynamic error, since its T will never match the correct runtime type (which
would be 'int').

[floitsch, 2015/02/03 13:34:21]

This seems to be very await specific (talking about 'future'). rename function?

[Johnni Winther, 2015/02/03 14:12:56]

It term 'flatten' is from the spec is used to describe the static typing of
await and type checking of return (no implemented yet).

[Johnni Winther, 2015/02/03 14:12:56]

Done.

+    if (type is InterfaceType) {
+      InterfaceType futureType = type.asInstanceOf(compiler.futureClass);
+      if (futureType != null) {
+        return flatten(futureType.typeArguments.first);
+      }
+    }
+    return type;
+  }
+
   DartType visitAwait(Await node) {
     DartType expressionType = analyze(node.expression);
-    DartType resultType = expressionType;
-    if (expressionType is InterfaceType) {
-      InterfaceType futureType =
-          expressionType.asInstanceOf(compiler.futureClass);
-      if (futureType != null) {
-        resultType = futureType.typeArguments.first;
-      }
-    }
-    return resultType;
+    return flatten(expressionType);
   }
 
   DartType visitYield(Yield node) {
     DartType resultType = analyze(node.expression);
     if (!node.hasStar) {
       if (currentAsyncMarker.isAsync) {
         resultType =
             compiler.streamClass.thisType.createInstantiation(
                 <DartType>[resultType]);
       } else {
@@ skipping 203 matching lines @@
 
   visitTypedef(Typedef node) {
     // Do not typecheck [Typedef] nodes.
   }
 
   visitNode(Node node) {
     compiler.internalError(node,
         'Unexpected node ${node.getObjectDescription()} in the type checker.');
   }
 }