Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 886353006: Port metrics to RPC (Closed)

Created:
5 years, 10 months ago by Cutch
Modified:
5 years, 10 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -114 lines) Patch
M runtime/observatory/lib/service_html.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/error_ref.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/metrics.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/metrics.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 4 chunks +12 lines, -11 lines 0 comments Download
M runtime/observatory/test/contexts_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/test/inbound_references_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/test/malformed_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/test/metrics_test.dart View 1 chunk +9 lines, -11 lines 0 comments Download
M runtime/observatory/test/mirror_references_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
A runtime/observatory/test/native_metrics_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
M runtime/observatory/test/string_escaping_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
D runtime/observatory/test/vm_metrics_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
M runtime/observatory/test/weak_properties_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/metrics.cc View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/metrics_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 8 chunks +67 lines, -27 lines 0 comments Download
M runtime/vm/service/service.idl View 3 chunks +41 lines, -2 lines 0 comments Download
M sdk/lib/profiler/profiler.dart View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
5 years, 10 months ago (2015-02-04 20:42:33 UTC) #2
turnidge
lgtm w/ c https://codereview.chromium.org/886353006/diff/20001/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/886353006/diff/20001/runtime/observatory/lib/src/service/object.dart#newcode1366 runtime/observatory/lib/src/service/object.dart:1366: return refreshDartMetrics().then((_) => refreshNativeMetrics()); return Future.wait([refreshDartMetrics(), ...
5 years, 10 months ago (2015-02-04 21:24:24 UTC) #3
Cutch
https://codereview.chromium.org/886353006/diff/20001/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/886353006/diff/20001/runtime/observatory/lib/src/service/object.dart#newcode1366 runtime/observatory/lib/src/service/object.dart:1366: return refreshDartMetrics().then((_) => refreshNativeMetrics()); On 2015/02/04 21:24:24, turnidge wrote: ...
5 years, 10 months ago (2015-02-04 21:27:12 UTC) #5
Cutch
5 years, 10 months ago (2015-02-04 21:28:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 43486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698