Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: runtime/observatory/test/metrics_test.dart

Issue 886353006: Port metrics to RPC (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/test/malformed_test.dart ('k') | runtime/observatory/test/mirror_references_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/test/metrics_test.dart
diff --git a/runtime/observatory/test/metrics_test.dart b/runtime/observatory/test/metrics_test.dart
index 9a72e23a95fd6729e8db2497ae88e12523a242cf..ef227c418732a9a8782d634cb62765e66d3124a2 100644
--- a/runtime/observatory/test/metrics_test.dart
+++ b/runtime/observatory/test/metrics_test.dart
@@ -17,27 +17,25 @@ void script() {
var tests = [
(Isolate isolate) =>
- isolate.getDeprecated('metrics').then((ServiceMap metrics) {
- expect(metrics['type'], equals('MetricList'));
- var members = metrics['members'];
- expect(members, isList);
- expect(members.length, equals(1));
- var counter = members[0];
+ isolate.refreshDartMetrics().then((Map metrics) {
+ expect(metrics.length, equals(1));
+ var counter = metrics['metrics/a.b.c'];
expect(counter.name, equals('a.b.c'));
expect(counter.value, equals(1234.5));
}),
(Isolate isolate) =>
- isolate.getDeprecated('metrics/a.b.c').then((ServiceMetric counter) {
+ isolate.invokeRpc('getIsolateMetric', { 'metricId': 'metrics/a.b.c' })
+ .then((ServiceMetric counter) {
expect(counter.name, equals('a.b.c'));
expect(counter.value, equals(1234.5));
-}),
+ }),
(Isolate isolate) =>
- isolate.getDeprecated('metrics/a.b.d').then((DartError err) {
+ isolate.invokeRpc('getIsolateMetric', { 'metricId': 'metrics/a.b.d' })
+ .then((DartError err) {
expect(err is DartError, isTrue);
-}),
-
+ }),
];
main(args) => runIsolateTests(args, tests, testeeBefore: script);
« no previous file with comments | « runtime/observatory/test/malformed_test.dart ('k') | runtime/observatory/test/mirror_references_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698