dart2js: Refactor how parameter stubs are handled.

dart2js: Refactor how parameter stubs are handled.

R=zarah@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43346

[floitsch, 2015-01-30 13:37:01]

floitsch@google.com changed reviewers:
+ herhut@google.com, zarah@google.com

[floitsch, 2015-01-30 13:37:02]

Obsoletes https://codereview.chromium.org/889693003/ and
https://codereview.chromium.org/871243003/

[floitsch, 2015-01-30 13:40:46]

Rebased.

[zarah, 2015-01-30 14:07:27]

The CQ bit was checked by zarah@google.com

[zarah, 2015-01-30 14:07:28]

lgtm

https://codereview.chromium.org/886053004/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/886053004/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/model.dart:403: /// If an stub's member can not
be torn off, the [callName] is `null`.
an -> a.

https://codereview.chromium.org/886053004/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart (right):

https://codereview.chromium.org/886053004/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart:207: // This
happens when a member is torn-off. In that case calls to the
nit: we sometimes write torn off and sometimes torn-off. I think it should be
without hyphen when used as a verb.

[commit-bot: I haz the power, 2015-01-30 14:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-30 14:10:59]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[floitsch, 2015-01-30 21:48:13]

https://codereview.chromium.org/886053004/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/886053004/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/model.dart:403: /// If an stub's member can not
be torn off, the [callName] is `null`.
On 2015/01/30 14:07:28, zarah wrote:
> an -> a.

Done.

https://codereview.chromium.org/886053004/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart (right):

https://codereview.chromium.org/886053004/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart:207: // This
happens when a member is torn-off. In that case calls to the
On 2015/01/30 14:07:28, zarah wrote:
> nit: we sometimes write torn off and sometimes torn-off. I think it should be
> without hyphen when used as a verb.

Done.

[floitsch, 2015-01-30 21:48:33]

Committed patchset #4 (id:60001) manually as 43346 (presubmit successful).