Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Issue 886053003: dart2dart: Remove the list of closureVariables from FunctionDefinitions. (Closed)

Created:
5 years, 10 months ago by Kevin Millikin (Google)
Modified:
5 years, 10 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2dart: Remove the list of closureVariables from FunctionDefinitions. Function definitions had a list of closure variables (which was always empty in the JS backend). This list has no code generation semantics because it is ignored by the Tree IR builder. Instead, when translating to Tree IR, a reference to an unbound closure variable implicitly 'declares' it. The closure variables were however used for the S-expression serialized representation. They can be eliminated here as well by using the same trick as the Tree IR builder. R=asgerf@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43337

Patch Set 1 #

Patch Set 2 : Restore inadvertently removed code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -196 lines) Patch
M pkg/analyzer2dart/test/sexpr_data.dart View 84 chunks +91 lines, -91 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 6 chunks +3 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 2 chunks +4 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 6 chunks +15 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_constprop_test.dart View 17 chunks +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart View 1 18 chunks +23 lines, -23 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 6 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
5 years, 10 months ago (2015-01-30 10:16:41 UTC) #1
asgerf
Much better! LGTM
5 years, 10 months ago (2015-01-30 10:58:14 UTC) #2
Kevin Millikin (Google)
5 years, 10 months ago (2015-01-30 13:20:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43337 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698