Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1863)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

Issue 886053003: dart2dart: Remove the list of closureVariables from FunctionDefinitions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Restore inadvertently removed code. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer2dart/test/sexpr_data.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
index 2de6fd1f0766fe1dfa61bc866274f540edf9c134..bba0a205551ba7e0d61a6bc8742939d2f2783707 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
@@ -248,10 +248,6 @@ abstract class IrBuilder {
/// or put it in its box, if necessary.
void _createFunctionParameter(ParameterElement parameterElement);
- /// Returns the list of closure variables declared in the given function or
- /// field initializer.
- List<ir.ClosureVariable> _getDeclaredClosureVariables(ExecutableElement elm);
-
/// Creates an access to the receiver from the current (or enclosing) method.
///
/// If inside a closure class, [buildThis] will redirect access through
@@ -608,8 +604,7 @@ abstract class IrBuilder {
ir.RunnableBody body = makeRunnableBody();
return new ir.FunctionDefinition(
element, state.functionParameters, body,
- state.localConstants, defaults,
- _getDeclaredClosureVariables(element));
+ state.localConstants, defaults);
}
}
@@ -628,8 +623,7 @@ abstract class IrBuilder {
ir.RunnableBody body = makeRunnableBody();
return new ir.ConstructorDefinition(
element, state.functionParameters, body, initializers,
- state.localConstants, defaults,
- _getDeclaredClosureVariables(element));
+ state.localConstants, defaults);
}
/// Create a super invocation where the method name and the argument structure
@@ -1575,7 +1569,7 @@ class DartIrBuilder extends IrBuilder {
DartIrBuilder(ConstantSystem constantSystem,
ExecutableElement currentElement,
- DartCapturedVariableInfo closureVariables)
+ DartCapturedVariableInfo closureVariables)
: dartState = new DartIrBuilderSharedState(closureVariables) {
_init(constantSystem, currentElement);
}
@@ -1720,11 +1714,6 @@ class DartIrBuilder extends IrBuilder {
return value;
}
- List<ir.ClosureVariable> _getDeclaredClosureVariables(
- ExecutableElement element) {
- return dartState.getClosureList(element);
- }
-
ir.Primitive buildThis() {
ir.Primitive thisPrim = new ir.This();
add(new ir.LetPrim(thisPrim));
@@ -1928,11 +1917,6 @@ class JsIrBuilder extends IrBuilder {
environment.update(scope.box, newBox);
}
- List<ir.ClosureVariable> _getDeclaredClosureVariables(
- ExecutableElement element) {
- return <ir.ClosureVariable>[];
- }
-
ir.Primitive buildThis() {
if (jsState.receiver != null) return jsState.receiver;
ir.Primitive thisPrim = new ir.This();
« no previous file with comments | « pkg/analyzer2dart/test/sexpr_data.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698