Issue 884793002: Reduce isolate startup time in debug mode by 20 millis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 884793002: Reduce isolate startup time in debug mode by 20 millis (Closed)

Created:
5 years, 10 months ago by Cutch

Modified:
5 years, 10 months ago

Reviewers:
koda, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Reduce isolate startup time in debug mode by 20 millis Before: CorelibIsolateStartup(RunTime): 34280 After: CorelibIsolateStartup(RunTime): 14836 R=koda@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=43252

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -5 lines)			Patch
M	runtime/vm/object.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+0 lines, -2 lines	1 comment	Download
M	runtime/vm/raw_object_snapshot.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

koda

lgtm https://codereview.chromium.org/884793002/diff/1/runtime/vm/raw_object.h File runtime/vm/raw_object.h (left): https://codereview.chromium.org/884793002/diff/1/runtime/vm/raw_object.h#oldcode501 runtime/vm/raw_object.h:501: ASSERT(Contains(reinterpret_cast<uword>(addr))); This is fine for now; it's unlikely ...

5 years, 10 months ago (2015-01-28 18:52:33 UTC) #4

Cutch

5 years, 10 months ago (2015-01-28 18:54:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43252 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages