runtime/vm/raw_object.h - Issue 884793002: Reduce isolate startup time in debug mode by 20 millis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/raw_object.h

Issue 884793002: Reduce isolate startup time in debug mode by 20 millis (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/raw_object.h

diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h

index 801668b5be5a9f7b6d98fbae94cd80cf14e15478..749ee4529173b39993d3390243aaa59c69eea920 100644

--- a/runtime/vm/raw_object.h

+++ b/runtime/vm/raw_object.h

@@ -497,8 +497,6 @@ class RawObject {

#if defined(DEBUG)

ValidateOverwrittenPointer(*addr);

#endif // DEBUG

- // Ensure that this object contains the addr.

- ASSERT(Contains(reinterpret_cast<uword>(addr)));

koda 2015/01/28 18:52:33 This is fine for now; it's unlikely to catch any b

VerifiedMemory::Write(const_cast<type*>(addr), value);

// Filter stores based on source and target.

if (!value->IsHeapObject()) return;

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »