Issue 884523003: Add support for ignoring the svn revision when getting the version, use this for gn build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 884523003: Add support for ignoring the svn revision when getting the version, use this for gn build (Closed)

Created:
5 years, 10 months ago by ricow1

Modified:
5 years, 10 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Add support for ignoring the svn revision when getting the version, use this for gn build R=zra@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43297

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -7 lines)			Patch
M	runtime/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/make_version.py	View	4 chunks	+9 lines, -5 lines	0 comments	Download
M	tools/utils.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

ricow1

5 years, 10 months ago (2015-01-29 16:55:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43297 (presubmit successful).