tools/utils.py - Issue 884523003: Add support for ignoring the svn revision when getting the version, use this for gn build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/utils.py

Issue 884523003: Add support for ignoring the svn revision when getting the version, use this for gn build (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/utils.py

diff --git a/tools/utils.py b/tools/utils.py

index 2e9272320669f876020f835389e526954241ef2a..55a54bc0eb51894d26f8a8331e0fc94a6f56bf25 100644

--- a/tools/utils.py

+++ b/tools/utils.py

@@ -278,13 +278,13 @@ def GetShortVersion():

version.major, version.minor, version.patch, version.prerelease,

version.prerelease_patch))

-def GetSemanticSDKVersion():

+def GetSemanticSDKVersion(ignore_svn_revision=False):

version = ReadVersionFile()

if not version:

return None

if version.channel == 'be':

- postfix = '-edge.%s' % GetSVNRevision()

+ postfix = '-edge' if ignore_svn_revision else '-edge.%s' % GetSVNRevision()

elif version.channel == 'dev':

postfix = '-dev.%s.%s' % (version.prerelease, version.prerelease_patch)

else:

« no previous file with comments | « tools/make_version.py ('k') | no next file » | no next file with comments »