Allows turning on checked mode on a per-isolate basis

Allows turning on checked mode on a per-isolate basis
using the embedding API.

R=regis@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43481

[zra, 2015-02-03 21:53:39]

zra@google.com changed reviewers:
+ regis@google.com, srdjan@google.com

[srdjan, 2015-02-03 22:04:13]

LGTM with comment

https://codereview.chromium.org/883263004/diff/1/runtime/vm/ast.cc
File runtime/vm/ast.cc (right):

https://codereview.chromium.org/883263004/diff/1/runtime/vm/ast.cc#newcode518
runtime/vm/ast.cc:518: if (FLAG_enable_type_checks ||
Isolate::Current()->checked_mode()) {
I would factor this out into Isolate::IsCheckedMode, inside would do:

return FLAG_enable_type_checks || checked_mode()

[regis, 2015-02-03 22:23:17]

Plumbing LGTM, but I have comments regarding the naming of this API.

https://codereview.chromium.org/883263004/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/883263004/diff/1/runtime/vm/class_finalizer.c...
runtime/vm/class_finalizer.cc:30: return FLAG_error_on_bad_type ||
Isolate::Current()->checked_mode();
--checked does not include --error-on-bad-type or --error-on-bad-override

--checked (same as --enable-checked-mode) means --enable-type-checks and
--enable-asserts. See parser.cc:53

Having a different meaning for "checked mode" in the API is confusing.

--error-on-bad-type and --error-on-bad-override are merely debugging help, but
not part of checked mode.

https://codereview.chromium.org/883263004/diff/1/runtime/vm/dart_api_impl_tes...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/883263004/diff/1/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:3618: Dart_IsolateSetCheckedMode(false);
As shown by this test, you cannot flip the isolate checked mode at runtime. It
is actually a compile time mode. It would be nice to reflect that in the name to
avoid confusion. Something like Dart_IsolateSetSafeCompilation?

"safe compilation" or "strict compilation" would be easier to distinguish from
"checked mode" flag.

[zra, 2015-02-03 23:47:12]

New patchsets have been uploaded after l-g-t-m from
srdjan@google.com,regis@google.com

[zra, 2015-02-03 23:51:54]

ptal

Renamed checked_mode -> strict_compilation.

Added a flag "has_compiled" to Isolate, which is set in Dart_Invoke(). The flag
is then checked in Dart_IsolateSetStrictCompilation(). Is it possible for an
Isolate to compile stuff before the first Dart_Invoke() call?

[regis, 2015-02-04 00:00:58]

LGTM!

https://codereview.chromium.org/883263004/diff/20001/runtime/vm/dart_api_impl...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/883263004/diff/20001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl_test.cc:3595: "int bad2() {\n"
not needed anymore

https://codereview.chromium.org/883263004/diff/20001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl_test.cc:3600: "int good2() {\n"
ditto

[zra, 2015-02-04 18:27:19]

New patchsets have been uploaded after l-g-t-m from regis@google.com

[zra, 2015-02-04 18:28:58]

Thanks!

https://codereview.chromium.org/883263004/diff/20001/runtime/vm/dart_api_impl...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/883263004/diff/20001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl_test.cc:3595: "int bad2() {\n"
On 2015/02/04 00:00:58, regis wrote:
> not needed anymore

Removed

https://codereview.chromium.org/883263004/diff/20001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl_test.cc:3600: "int good2() {\n"
On 2015/02/04 00:00:58, regis wrote:
> ditto

Removed

[zra, 2015-02-04 18:33:16]

Committed patchset #3 (id:40001) manually as r43481 (presubmit successful).