Allows turning on checked mode on a per-isolate basis

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/builtin.h"
 #include "include/dart_api.h"
 #include "include/dart_debugger_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 #include "platform/assert.h"
@@ skipping 3562 matching lines @@
       Dart_CreateIsolate(NULL, NULL, bin::snapshot_buffer,
                          reinterpret_cast<void*>(mydata),
                          &err);
   EXPECT(isolate != NULL);
   EXPECT_EQ(mydata, reinterpret_cast<intptr_t>(Dart_CurrentIsolateData()));
   EXPECT_EQ(mydata, reinterpret_cast<intptr_t>(Dart_IsolateData(isolate)));
   Dart_ShutdownIsolate();
 }
 
 
+TEST_CASE(IsolateSetCheckedMode) {
+  const char* kScriptChars =
+      "int bad1() {\n"
+      "  int foo = 'string';\n"
+      "  return foo;\n"
+      "}\n"
+      "\n"
+      "int good1() {\n"
+      "  int five = 5;\n"
+      "  return five;"
+      "}\n"
+      "\n"
+      "int bad2() {\n"
+      "  int foo = 'string';\n"
+      "  return foo;\n"
+      "}\n"
+      "\n"
+      "int good2() {\n"
+      "  int five = 5;\n"
+      "  return five;"
+      "}\n"
+      "\n";
+  Dart_Handle result;
+
+  // Create a test library and Load up a test script in it.
+  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
+  Dart_IsolateSetCheckedMode(true);
+
+  result = Dart_Invoke(lib, NewString("bad1"), 0, NULL);
+  EXPECT_ERROR(result, "Unhandled exception:\n"
+      "type 'String' is not a subtype of type 'int' of 'foo'");
+
+  result = Dart_Invoke(lib, NewString("good1"), 0, NULL);
+  EXPECT_VALID(result);
+
+  Dart_IsolateSetCheckedMode(false);

[regis, 2015/02/03 22:23:17]

As shown by this test, you cannot flip the isolate checked mode at runtime. It
is actually a compile time mode. It would be nice to reflect that in the name to
avoid confusion. Something like Dart_IsolateSetSafeCompilation?

"safe compilation" or "strict compilation" would be easier to distinguish from
"checked mode" flag.

+
+  result = Dart_Invoke(lib, NewString("bad2"), 0, NULL);
+  EXPECT_VALID(result);
+
+  result = Dart_Invoke(lib, NewString("good2"), 0, NULL);
+  EXPECT_VALID(result);
+}
+
+
 TEST_CASE(DebugName) {
   Dart_Handle debug_name = Dart_DebugName();
   EXPECT_VALID(debug_name);
   EXPECT(Dart_IsString(debug_name));
 }
 
 
 static void MyMessageNotifyCallback(Dart_Isolate dest_isolate) {
 }
 
@@ skipping 5249 matching lines @@
     result = Dart_Invoke(lib,
                          NewString("testView16"),
                          1,
                          dart_args);
     EXPECT_VALID(result);
     EXPECT(Dart_IsString(result));
   }
 }
 
 }  // namespace dart