pkg/logging: expose static sorted const list of all levels

pkg/logging: expose static sorted const list of all levels

BUG= https://code.google.com/p/dart/issues/detail?id=15321
R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30676

[kevmoo-old, 2013-11-26 19:12:46]

PTAL

[kevmoo-old, 2013-11-26 19:23:13]

https://codereview.chromium.org/88323004/diff/20001/pkg/logging/test/logging_...
File pkg/logging/test/logging_test.dart (right):

https://codereview.chromium.org/88323004/diff/20001/pkg/logging/test/logging_...
pkg/logging/test/logging_test.dart:51: unsorted.sort();
sort uses static Comparable.compare which calls the instance compareTo

[Siggi Cherem (dart-lang), 2013-11-26 19:25:49]

lgtm - but before submitting, can you update the version to be: "0.9.1-dev"

That will make it visible that we have some unreleased changes so next time we
want to release the package we can update it to 0.9.1

I guess the current changes are non-breaking, so we could also do: 0.9.0+1

Thoughts?

https://codereview.chromium.org/88323004/diff/20001/pkg/logging/test/logging_...
File pkg/logging/test/logging_test.dart (right):

https://codereview.chromium.org/88323004/diff/20001/pkg/logging/test/logging_...
pkg/logging/test/logging_test.dart:64: expect(() => new Logger('.c'),
throwsArgumentError);
mmm. I wonder if this should be an argument error or a format error

[kevmoo-old, 2013-11-26 20:39:32]

Updated the pubspec.

I bumped version to 0.9.1, since new features were added
I also bumped the required version of collection_helpers, since the current impl
depends on at least 0.9.1

https://codereview.chromium.org/88323004/diff/20001/pkg/logging/test/logging_...
File pkg/logging/test/logging_test.dart (right):

https://codereview.chromium.org/88323004/diff/20001/pkg/logging/test/logging_...
pkg/logging/test/logging_test.dart:64: expect(() => new Logger('.c'),
throwsArgumentError);
On 2013/11/26 19:25:49, Siggi Cherem (dart-lang) wrote:
> mmm. I wonder if this should be an argument error or a format error

It's arguable at best. I didn't change the existing behavior w/ the fix...just
made the check more specific.

I can't see a good argument for changing the impl now

[Siggi Cherem (dart-lang), 2013-11-26 20:45:02]

lgtm, thanks Kevin

[kevmoo-old, 2013-11-26 20:50:50]

Committed patchset #3 manually as r30676 (presubmit successful).