pkg/logging: expose static sorted const list of all levels

pkg/logging/test/logging_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 library logging_test;
 
 import 'package:logging/logging.dart';
 import 'package:unittest/unittest.dart';
 
@@ skipping 11 matching lines @@
     expect(level1 < level2, isTrue);
     expect(level2 >= level1, isTrue);
     expect(level2 > level1, isTrue);
 
     var level3 = const Level('NOT_REAL3', 253);
     expect(level1, isNot(same(level3))); // different instances
     expect(level1, equals(level3)); // same value.
   });
 
   test('default levels are in order', () {
-    final levels = const [
-        Level.ALL, Level.FINEST, Level.FINER, Level.FINE, Level.CONFIG,
-        Level.INFO, Level.WARNING, Level.SEVERE, Level.SHOUT, Level.OFF
-      ];
+    final levels = Level.LEVELS;
 
     for (int i = 0; i < levels.length; i++) {
       for (int j = i + 1; j < levels.length; j++) {
         expect(levels[i] < levels[j], isTrue);
       }
     }
   });
 
   test('levels are comparable', () {
     final unsorted = [
         Level.INFO, Level.CONFIG, Level.FINE, Level.SHOUT, Level.OFF,
         Level.FINER, Level.ALL, Level.WARNING, Level.FINEST,  Level.SEVERE,
       ];
-    final sorted = const [
-        Level.ALL, Level.FINEST, Level.FINER, Level.FINE, Level.CONFIG,
-        Level.INFO, Level.WARNING, Level.SEVERE, Level.SHOUT, Level.OFF
-      ];
+
+    final sorted = Level.LEVELS;
+
     expect(unsorted, isNot(orderedEquals(sorted)));
 
-    unsorted.sort((a, b) => a.compareTo(b));
+    unsorted.sort();

[kevmoo-old, 2013/11/26 19:23:13]

sort uses static Comparable.compare which calls the instance compareTo

     expect(unsorted, orderedEquals(sorted));
   });
 
   test('levels are hashable', () {
     var map = new Map<Level, String>();
     map[Level.INFO] = 'info';
     map[Level.SHOUT] = 'shout';
     expect(map[Level.INFO], same('info'));
     expect(map[Level.SHOUT], same('shout'));
   });
 
   test('logger name cannot start with a "." ', () {
-    expect(() => new Logger('.c'), throws);
+    expect(() => new Logger('.c'), throwsArgumentError);

[Siggi Cherem (dart-lang), 2013/11/26 19:25:49]

mmm. I wonder if this should be an argument error or a format error

[kevmoo-old, 2013/11/26 20:39:33]

It's arguable at best. I didn't change the existing behavior w/ the fix...just
made the check more specific.

I can't see a good argument for changing the impl now

   });
 
   test('logger naming is hierarchical', () {
     Logger c = new Logger('a.b.c');
     expect(c.name, equals('c'));
     expect(c.parent.name, equals('b'));
     expect(c.parent.parent.name, equals('a'));
     expect(c.parent.parent.parent.name, equals(''));
     expect(c.parent.parent.parent.parent, isNull);
   });
@@ skipping 338 matching lines @@
             'SHOUT: 10']));
 
       expect(cMessages, equals([
             // 1 - 7 are lower in the hierarchy
             // 'FINE: 8' is not loggable
             'WARNING: 9',
             'SHOUT: 10']));
     });
   });
 }