Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 879483005: Revert "dart2js cps: Handle optional parameters in builder." (Closed)

Created:
5 years, 10 months ago by asgerf
Modified:
5 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "dart2js cps: Handle optional parameters in builder." This reverts commit 43643. BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=43679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -164 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 10 chunks +29 lines, -138 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 3 chunks +14 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 3 chunks +48 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_basic_test.dart View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
asgerf
TBR Fails in checked-mode in dart2dart.
5 years, 10 months ago (2015-02-10 16:19:03 UTC) #2
asgerf
On 2015/02/10 16:19:03, asgerf wrote: > TBR > > Fails in checked-mode in dart2dart. Can't ...
5 years, 10 months ago (2015-02-10 16:27:24 UTC) #3
Johnni Winther
lgtm
5 years, 10 months ago (2015-02-11 08:31:50 UTC) #4
asgerf
5 years, 10 months ago (2015-02-11 10:19:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43679 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698