Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

Issue 879483005: Revert "dart2js cps: Handle optional parameters in builder." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.ir_builder; 5 library dart2js.ir_builder;
6 6
7 import '../constants/expressions.dart'; 7 import '../constants/expressions.dart';
8 import '../constants/values.dart' show PrimitiveConstantValue; 8 import '../constants/values.dart' show PrimitiveConstantValue;
9 import '../dart_types.dart'; 9 import '../dart_types.dart';
10 import '../dart2jslib.dart'; 10 import '../dart2jslib.dart';
(...skipping 713 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 (k) => new ir.InvokeConstructor(type, element, selector, k, arguments)); 724 (k) => new ir.InvokeConstructor(type, element, selector, k, arguments));
725 } 725 }
726 726
727 /// Create a string concatenation of the [arguments]. 727 /// Create a string concatenation of the [arguments].
728 ir.Primitive buildStringConcatenation(List<ir.Primitive> arguments) { 728 ir.Primitive buildStringConcatenation(List<ir.Primitive> arguments) {
729 assert(isOpen); 729 assert(isOpen);
730 return _continueWithExpression( 730 return _continueWithExpression(
731 (k) => new ir.ConcatenateStrings(k, arguments)); 731 (k) => new ir.ConcatenateStrings(k, arguments));
732 } 732 }
733 733
734 /// Create an invocation of [local] where the argument structure is defined
735 /// by [selector] and the argument values are defined by [arguments].
736 ir.Primitive buildLocalInvocation(LocalElement local,
737 Selector selector,
738 List<ir.Definition> arguments) {
739 return _buildInvokeCall(buildLocalGet(local), selector, arguments);
740 }
741
734 /// Create an invocation of the [functionExpression] where the argument 742 /// Create an invocation of the [functionExpression] where the argument
735 /// structure are defined by [selector] and the argument values are defined by 743 /// structure are defined by [selector] and the argument values are defined by
736 /// [arguments]. 744 /// [arguments].
737 ir.Primitive buildFunctionExpressionInvocation( 745 ir.Primitive buildFunctionExpressionInvocation(
738 ir.Primitive functionExpression, 746 ir.Primitive functionExpression,
739 Selector selector, 747 Selector selector,
740 List<ir.Definition> arguments) { 748 List<ir.Definition> arguments) {
741 return _buildInvokeCall(functionExpression, selector, arguments); 749 return _buildInvokeCall(functionExpression, selector, arguments);
742 } 750 }
743 751
(...skipping 1264 matching lines...) Expand 10 before | Expand all | Expand 10 after
2008 ClosureEnvironment(this.selfReference, this.thisLocal, this.freeVariables); 2016 ClosureEnvironment(this.selfReference, this.thisLocal, this.freeVariables);
2009 } 2017 }
2010 2018
2011 /// Information about which variables are captured by a nested function. 2019 /// Information about which variables are captured by a nested function.
2012 /// 2020 ///
2013 /// This is used by the [DartIrBuilder] instead of [ClosureScope] and 2021 /// This is used by the [DartIrBuilder] instead of [ClosureScope] and
2014 /// [ClosureEnvironment]. 2022 /// [ClosureEnvironment].
2015 abstract class DartCapturedVariableInfo { 2023 abstract class DartCapturedVariableInfo {
2016 Iterable<Local> get capturedVariables; 2024 Iterable<Local> get capturedVariables;
2017 } 2025 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/compile_time_constants.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698