Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878243002: Cleanup: use const reference for ParsedFunction where possible. (Closed)

Created:
5 years, 11 months ago by srdjan
Modified:
5 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Cleanup: use const reference for ParsedFunction where possible. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=43226

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -83 lines) Patch
M runtime/vm/ast_transformer.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/ast_transformer.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/block_scheduler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/compiler.cc View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_allocator.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 2 3 4 4 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 3 4 14 chunks +20 lines, -21 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 3 4 3 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 7 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 4 3 chunks +3 lines, -5 lines 0 comments Download
M runtime/vm/regexp_assembler.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 10 months ago (2015-01-28 00:10:17 UTC) #2
rmacnak
LGTM
5 years, 10 months ago (2015-01-28 00:26:14 UTC) #3
srdjan
5 years, 10 months ago (2015-01-28 00:41:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as r43226 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698