Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: runtime/vm/intermediate_language.h

Issue 878243002: Cleanup: use const reference for ParsedFunction where possible. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 43213)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -1300,7 +1300,7 @@
class GraphEntryInstr : public BlockEntryInstr {
public:
- GraphEntryInstr(const ParsedFunction* parsed_function,
+ GraphEntryInstr(const ParsedFunction& parsed_function,
TargetEntryInstr* normal_entry,
intptr_t osr_id);
@@ -1349,7 +1349,7 @@
TargetEntryInstr* normal_entry() const { return normal_entry_; }
const ParsedFunction& parsed_function() const {
- return *parsed_function_;
+ return parsed_function_;
}
const GrowableArray<CatchBlockEntryInstr*>& catch_entries() const {
@@ -1366,7 +1366,7 @@
virtual void ClearPredecessors() {}
virtual void AddPredecessor(BlockEntryInstr* predecessor) { UNREACHABLE(); }
- const ParsedFunction* parsed_function_;
+ const ParsedFunction& parsed_function_;
TargetEntryInstr* normal_entry_;
GrowableArray<CatchBlockEntryInstr*> catch_entries_;
// Indirect targets are blocks reachable only through indirect gotos.
@@ -7921,7 +7921,7 @@
static Environment* From(Isolate* isolate,
const GrowableArray<Definition*>& definitions,
intptr_t fixed_parameter_count,
- const ParsedFunction* parsed_function);
+ const ParsedFunction& parsed_function);
void set_locations(Location* locations) {
ASSERT(locations_ == NULL);
@@ -7967,7 +7967,7 @@
return fixed_parameter_count_;
}
- const Code& code() const { return parsed_function_->code(); }
+ const Code& code() const { return parsed_function_.code(); }
Environment* DeepCopy(Isolate* isolate) const {
return DeepCopy(isolate, Length());
@@ -7996,7 +7996,7 @@
Environment(intptr_t length,
intptr_t fixed_parameter_count,
intptr_t deopt_id,
- const ParsedFunction* parsed_function,
+ const ParsedFunction& parsed_function,
Environment* outer)
: values_(length),
locations_(NULL),
@@ -8010,7 +8010,7 @@
Location* locations_;
const intptr_t fixed_parameter_count_;
intptr_t deopt_id_;
- const ParsedFunction* parsed_function_;
+ const ParsedFunction& parsed_function_;
Environment* outer_;
DISALLOW_COPY_AND_ASSIGN(Environment);
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698