Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 876603003: VM: Refactor more intrinsics of GrowableList to use IR builder. (Closed)

Created:
5 years, 10 months ago by Florian Schneider
Modified:
5 years, 10 months ago
Reviewers:
zerny-google
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Refactor more intrinsics of GrowableList to use IR builder. Removing the platform-specific code. Also contains an unrelated clean-up in snapshot code. R=zerny@google.com Committed: https://code.google.com/p/dart/source/detail?r=43283

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -463 lines) Patch
M runtime/vm/intrinsifier.cc View 1 7 chunks +131 lines, -7 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 10 months ago (2015-01-28 14:22:38 UTC) #2
zerny-google
lgtm. How does this show on list-heavy benchmarks? https://codereview.chromium.org/876603003/diff/1/runtime/vm/intrinsifier.cc File runtime/vm/intrinsifier.cc (right): https://codereview.chromium.org/876603003/diff/1/runtime/vm/intrinsifier.cc#newcode688 runtime/vm/intrinsifier.cc:688: Definition* ...
5 years, 10 months ago (2015-01-28 14:33:10 UTC) #3
Florian Schneider
https://codereview.chromium.org/876603003/diff/1/runtime/vm/intrinsifier.cc File runtime/vm/intrinsifier.cc (right): https://codereview.chromium.org/876603003/diff/1/runtime/vm/intrinsifier.cc#newcode688 runtime/vm/intrinsifier.cc:688: Definition* null_def = builder.AddDefinition( On 2015/01/28 14:33:10, zerny-google wrote: ...
5 years, 10 months ago (2015-01-29 12:48:14 UTC) #4
Florian Schneider
5 years, 10 months ago (2015-01-29 13:39:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as r43283 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698