Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 876603003: VM: Refactor more intrinsics of GrowableList to use IR builder. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier.cc ('k') | runtime/vm/intrinsifier_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_arm.cc
===================================================================
--- runtime/vm/intrinsifier_arm.cc (revision 43193)
+++ runtime/vm/intrinsifier_arm.cc (working copy)
@@ -142,94 +142,6 @@
}
-void Intrinsifier::GrowableArrayGetIndexed(Assembler* assembler) {
- Label fall_through;
-
- __ ldr(R0, Address(SP, + 0 * kWordSize)); // Index
- __ ldr(R1, Address(SP, + 1 * kWordSize)); // Array
-
- __ tst(R0, Operand(kSmiTagMask));
- __ b(&fall_through, NE); // Index is not an smi, fall through
-
- // Range check.
- __ ldr(R6, FieldAddress(R1, GrowableObjectArray::length_offset()));
- __ cmp(R0, Operand(R6));
-
- ASSERT(kSmiTagShift == 1);
- // array element at R6 + R0 * 2 + Array::data_offset - 1
- __ ldr(R6, FieldAddress(R1, GrowableObjectArray::data_offset()), CC); // data
- __ add(R6, R6, Operand(R0, LSL, 1), CC);
- __ ldr(R0, FieldAddress(R6, Array::data_offset()), CC);
- __ bx(LR, CC);
- __ Bind(&fall_through);
-}
-
-
-// Set value into growable object array at specified index.
-// On stack: growable array (+2), index (+1), value (+0).
-void Intrinsifier::GrowableArraySetIndexed(Assembler* assembler) {
- if (FLAG_enable_type_checks) {
- return;
- }
- Label fall_through;
- __ ldr(R1, Address(SP, 1 * kWordSize)); // Index.
- __ ldr(R0, Address(SP, 2 * kWordSize)); // GrowableArray.
- __ tst(R1, Operand(kSmiTagMask));
- __ b(&fall_through, NE); // Non-smi index.
- // Range check using _length field.
- __ ldr(R2, FieldAddress(R0, GrowableObjectArray::length_offset()));
- __ cmp(R1, Operand(R2));
- // Runtime throws exception.
- __ b(&fall_through, CS);
- __ ldr(R0, FieldAddress(R0, GrowableObjectArray::data_offset())); // data.
- __ ldr(R2, Address(SP, 0 * kWordSize)); // Value.
- // Note that R1 is Smi, i.e, times 2.
- ASSERT(kSmiTagShift == 1);
- __ add(R1, R0, Operand(R1, LSL, 1));
- __ StoreIntoObject(R0, FieldAddress(R1, Array::data_offset()), R2);
- __ Ret();
- __ Bind(&fall_through);
-}
-
-
-// Set length of growable object array. The length cannot
-// be greater than the length of the data container.
-// On stack: growable array (+1), length (+0).
-void Intrinsifier::GrowableArraySetLength(Assembler* assembler) {
- Label fall_through;
- __ ldr(R0, Address(SP, 1 * kWordSize)); // Growable array.
- __ ldr(R1, Address(SP, 0 * kWordSize)); // Length value.
- __ tst(R1, Operand(kSmiTagMask));
- __ b(&fall_through, NE); // Non-smi length.
- __ StoreIntoSmiField(FieldAddress(R0, GrowableObjectArray::length_offset()),
- R1);
- __ Ret();
- __ Bind(&fall_through);
-}
-
-
-// Set data of growable object array.
-// On stack: growable array (+1), data (+0).
-void Intrinsifier::GrowableArraySetData(Assembler* assembler) {
- if (FLAG_enable_type_checks) {
- return;
- }
- Label fall_through;
- __ ldr(R1, Address(SP, 0 * kWordSize)); // Data.
- // Check that data is an ObjectArray.
- __ tst(R1, Operand(kSmiTagMask));
- __ b(&fall_through, EQ); // Data is Smi.
- __ CompareClassId(R1, kArrayCid, R0);
- __ b(&fall_through, NE);
- __ ldr(R0, Address(SP, 1 * kWordSize)); // Growable array.
- __ StoreIntoObject(R0,
- FieldAddress(R0, GrowableObjectArray::data_offset()),
- R1);
- __ Ret();
- __ Bind(&fall_through);
-}
-
-
// Add an element to growable array if it doesn't need to grow, otherwise
// call into regular code.
// On stack: growable array (+1), value (+0).
« no previous file with comments | « runtime/vm/intrinsifier.cc ('k') | runtime/vm/intrinsifier_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698