Make AnalysisServer.onAnalysisComplete a Future and wait for it before refactoring.

Make AnalysisServer.onAnalysisComplete a Future and wait for it before refactoring.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43158

[Brian Wilkerson, 2015-01-26 21:26:32]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Brian Wilkerson, 2015-01-26 21:26:32]

https://codereview.chromium.org/875163002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/875163002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:245: return new Future(() =>
onAnalysisComplete);
This concerns me. Given what I think I know about futures and IO, I think this
will prevent IO from happening until analysis has completed, even with Dan's
changes.

[scheglov, 2015-01-26 22:05:53]

PTAL

https://codereview.chromium.org/875163002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/875163002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:245: return new Future(() =>
onAnalysisComplete);
On 2015/01/26 21:26:32, Brian Wilkerson wrote:
> This concerns me. Given what I think I know about futures and IO, I think this
> will prevent IO from happening until analysis has completed, even with Dan's
> changes.

Acknowledged.

[Brian Wilkerson, 2015-01-26 22:30:46]

LGTM

[scheglov, 2015-01-26 22:31:57]

Committed patchset #2 (id:20001) manually as 43158 (presubmit successful).

[Paul Berry, 2015-01-26 22:32:11]

lgtm

https://codereview.chromium.org/875163002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/875163002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:365: return
server.onAnalysisComplete.then((_) {
As we discussed in person, it would be nice in a future CL to only do this for
non-local refactorings.  Can we have a TODO comment to remind us about that?