pkg/analysis_server/test/domain_execution_test.dart - Issue 875163002: Make AnalysisServer.onAnalysisComplete a Future and wait for it before refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/domain_execution_test.dart

Issue 875163002: Make AnalysisServer.onAnalysisComplete a Future and wait for it before refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use Completer instead of busy loop Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/edit/edit_domain.dart ('K') | « pkg/analysis_server/test/domain_analysis_test.dart ('k') | pkg/analysis_server/test/mocks.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/domain_execution_test.dart

diff --git a/pkg/analysis_server/test/domain_execution_test.dart b/pkg/analysis_server/test/domain_execution_test.dart

index dc912de6b3b87a23101fe1a69e92aad15c8db092..fd63c423c29c5a073367fa03eecfff171138e962 100644

--- a/pkg/analysis_server/test/domain_execution_test.dart

+++ b/pkg/analysis_server/test/domain_execution_test.dart

@@ -196,7 +196,6 @@ main() {

AnalysisServer server = new AnalysisServerMock();

when(server.getAnalysisContexts()).thenReturn([context]);

when(server.contextDirectoryManager).thenReturn(manager);

- when(server.isAnalysisComplete()).thenReturn(false);

StreamController controller = new StreamController.broadcast(sync: true);

when(server.onFileAnalyzed).thenReturn(controller.stream);

« pkg/analysis_server/lib/src/edit/edit_domain.dart ('K') | « pkg/analysis_server/test/domain_analysis_test.dart ('k') | pkg/analysis_server/test/mocks.dart » ('j') | no next file with comments »