Issue 873133003: Fix type annotations that violate subtyping constraint on overriden methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 873133003: Fix type annotations that violate subtyping constraint on overriden methods. (Closed)

Created:
5 years, 10 months ago by herhut

Modified:
5 years, 10 months ago

Reviewers:
Johnni Winther, floitsch

CC:
reviews_dartlang.org, fabiostrocco_gmail.com, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Fix type annotations that violate subtyping constraint on overriden methods. BUG= R=floitsch@google.com, johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=43383

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	pkg/compiler/lib/src/dart_types.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/elements/modelx.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/resolution/signatures.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

herhut

As discussed at https://groups.google.com/a/dartlang.org/forum/#!topic/compiler-dev/DAcnoauqNNQ .

5 years, 10 months ago (2015-01-29 15:32:21 UTC) #2

herhut

5 years, 10 months ago (2015-02-03 09:13:32 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43383 (presubmit successful).