Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: pkg/compiler/lib/src/resolution/signatures.dart

Issue 873133003: Fix type annotations that violate subtyping constraint on overriden methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/compiler/lib/src/elements/modelx.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of resolution; 5 part of resolution;
6 6
7 /** 7 /**
8 * [SignatureResolver] resolves function signatures. 8 * [SignatureResolver] resolves function signatures.
9 */ 9 */
10 class SignatureResolver extends MappingVisitor<FormalElementX> { 10 class SignatureResolver extends MappingVisitor<FormalElementX> {
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 link.head.asIdentifier() != null || link.head.asSend() != null)); 119 link.head.asIdentifier() != null || link.head.asSend() != null));
120 if (fieldElement != null) { 120 if (fieldElement != null) {
121 element.typeCache = fieldElement.computeType(compiler); 121 element.typeCache = fieldElement.computeType(compiler);
122 } else { 122 } else {
123 element.typeCache = const DynamicType(); 123 element.typeCache = const DynamicType();
124 } 124 }
125 } 125 }
126 } 126 }
127 } 127 }
128 128
129 Element visitIdentifier(Identifier node) { 129 FormalElementX visitIdentifier(Identifier node) {
130 return createParameter(node, null); 130 return createParameter(node, null);
131 } 131 }
132 132
133 Identifier getParameterName(Send node) { 133 Identifier getParameterName(Send node) {
134 var identifier = node.selector.asIdentifier(); 134 var identifier = node.selector.asIdentifier();
135 if (identifier != null) { 135 if (identifier != null) {
136 // Normal parameter: [:Type name:]. 136 // Normal parameter: [:Type name:].
137 return identifier; 137 return identifier;
138 } else { 138 } else {
139 // Function type parameter: [:void name(DartType arg):]. 139 // Function type parameter: [:void name(DartType arg):].
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 380
381 DartType resolveReturnType(TypeAnnotation annotation) { 381 DartType resolveReturnType(TypeAnnotation annotation) {
382 if (annotation == null) return const DynamicType(); 382 if (annotation == null) return const DynamicType();
383 DartType result = resolver.resolveTypeAnnotation(annotation); 383 DartType result = resolver.resolveTypeAnnotation(annotation);
384 if (result == null) { 384 if (result == null) {
385 return const DynamicType(); 385 return const DynamicType();
386 } 386 }
387 return result; 387 return result;
388 } 388 }
389 } 389 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/elements/modelx.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698