Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 872643008: Fix bug in processing of latent breakpoints (Closed)

Created:
5 years, 10 months ago by hausner
Modified:
5 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, keertip
Visibility:
Public.

Description

Fix bug in processing of latent breakpoints Debugger hangs when encountering a url that has no match in any of the loaded libraries. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=43662

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M runtime/vm/debugger.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M tests/standalone/debugger/deferred_code_test.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hausner
5 years, 10 months ago (2015-02-10 18:39:47 UTC) #2
Cutch
Would be nice to have a test for this. LGTM
5 years, 10 months ago (2015-02-10 18:42:22 UTC) #3
Cutch
lgtm
5 years, 10 months ago (2015-02-10 19:09:02 UTC) #5
hausner
Here is a test. In the unlikely case that we'll have this same bug again ...
5 years, 10 months ago (2015-02-10 19:09:23 UTC) #6
hausner
5 years, 10 months ago (2015-02-10 19:12:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r43662 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698