Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: runtime/vm/debugger.cc

Issue 872643008: Fix bug in processing of latent breakpoints (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/standalone/debugger/deferred_code_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 43659)
+++ runtime/vm/debugger.cc (working copy)
@@ -2401,12 +2401,14 @@
GrowableObjectArray::Handle(isolate_->object_store()->libraries());
while (bpt != NULL) {
url = bpt->url();
+ bool found_match = false;
for (intptr_t i = 0; i < libs.Length(); i++) {
lib ^= libs.At(i);
script = lib.LookupScript(url);
if (!script.IsNull()) {
// Found a script with matching url for this latent breakpoint.
// Unlink the latent breakpoint from the list.
+ found_match = true;
SourceBreakpoint* matched_bpt = bpt;
bpt = bpt->next();
if (prev_bpt == NULL) {
@@ -2471,6 +2473,16 @@
}
}
}
+ if (!found_match) {
+ // No matching url found in any of the libraries.
+ if (FLAG_verbose_debug) {
+ OS::Print("No match found for latent breakpoint id "
+ "%" Pd " with url '%s'\n",
+ bpt->id(),
+ url.ToCString());
+ }
+ bpt = bpt->next();
+ }
}
}
« no previous file with comments | « no previous file | tests/standalone/debugger/deferred_code_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698