Issue 872403002: Don't create builders to determine if a native class is trivial or not.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 872403002: Don't create builders to determine if a native class is trivial or not. (Closed)

Created:
5 years, 11 months ago by floitsch

Modified:
5 years, 11 months ago

Reviewers:
herhut

CC:
reviews_dartlang.org, zarah, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Don't create builders to determine if a native class is trivial or not. Also use `emitClass` to emit the native classes (instead of duplicating the code). R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=43132

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -89 lines)			Patch
M	pkg/compiler/lib/src/js_emitter/native_emitter.dart	View	6 chunks	+23 lines, -78 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View	4 chunks	+4 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

floitsch

5 years, 11 months ago (2015-01-26 13:43:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43132 (presubmit successful).