Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 872403002: Don't create builders to determine if a native class is trivial or not. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
index 7ee54daa7a74fd61f9ccff0ba8d098780e408c64..ae3a685ddc9e7e5ce47920ff37f7ed36fbce6bc7 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
@@ -52,8 +52,8 @@ class OldEmitter implements Emitter {
final Map<String, String> mangledGlobalFieldNames = <String, String>{};
final Set<String> recordedMangledNames = new Set<String>();
- final Map<ClassElement, Map<String, jsAst.Expression>> additionalProperties =
- new Map<ClassElement, Map<String, jsAst.Expression>>();
+ final Map<Class, Map<String, jsAst.Expression>> additionalProperties =
+ new Map<Class, Map<String, jsAst.Expression>>();
List<TypedefElement> get typedefsNeededForReflection =>
task.typedefsNeededForReflection;
@@ -716,9 +716,6 @@ class OldEmitter implements Emitter {
}
void emitClass(Class cls, ClassBuilder enclosingBuilder) {
- // Native classes are handled by the native emitter.
- assert(!cls.isNative || cls.onlyForRti);
-
ClassElement classElement = cls.element;
compiler.withCurrentElement(classElement, () {
if (compiler.hasIncrementalSupport) {
@@ -726,7 +723,7 @@ class OldEmitter implements Emitter {
cachedClassBuilders.putIfAbsent(classElement, () {
ClassBuilder builder = new ClassBuilder(classElement, namer);
classEmitter.emitClass(
- cls, builder, additionalProperties[classElement]);
+ cls, builder, additionalProperties[cls]);
return builder;
});
invariant(classElement, cachedBuilder.fields.isEmpty);
@@ -736,7 +733,7 @@ class OldEmitter implements Emitter {
enclosingBuilder.properties.addAll(cachedBuilder.properties);
} else {
classEmitter.emitClass(
- cls, enclosingBuilder, additionalProperties[classElement]);
+ cls, enclosingBuilder, additionalProperties[cls]);
}
});
}
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698