dart2js: add work-around hack for try.

dart2js: add work-around hack for try.

Committed: https://code.google.com/p/dart/source/detail?r=43109

[floitsch, 2015-01-23 15:39:49]

floitsch@google.com changed reviewers:
+ ahe@google.com, zarah@google.com

[floitsch, 2015-01-23 15:39:50]

TBR.

[floitsch, 2015-01-23 15:40:11]

Committed patchset #1 (id:1) manually as 43109 (presubmit successful).

[ahe, 2015-01-28 07:22:37]

LGTM with comments.

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:265: /// HACK for Try.
This is not for Try Dart. This is for incremental compilation.

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:269: bool onlyForRti =
_task.typeTestRegistry.rtiNeededClasses.contains(element);
For incremental compilation, this should probably always be false.

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:276: Holder holder =
_registry.registerHolder(holderName);
I'm not sure I understand what a holder is. Does this help you generate only the
A-Z objects that are actually used?

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:278:
_compiler.codegenWorld.directlyInstantiatedClasses.contains(element);
For incremental compilation, my guess is that it would be better if this was
always true.

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:283: onlyForRti:
onlyForRti,
As mentioned above, the above two arguments should probably always have a fixed
value. This is because they are computed based on information that varies based
on how the program changes. Generally, those things are candidates for things
that should be avoided during incremental compilation.

https://codereview.chromium.org/871073002/diff/1/pkg/dart2js_incremental/lib/...
File pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/871073002/diff/1/pkg/dart2js_incremental/lib/...
pkg/dart2js_incremental/lib/library_updater.dart:70: Class;
Add newline between imports.

[floitsch, 2015-01-28 16:25:05]

Addressed in https://codereview.chromium.org/885673002

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:265: /// HACK for Try.
On 2015/01/28 07:22:37, ahe wrote:
> This is not for Try Dart. This is for incremental compilation.

Renamed function to buildClassWithFieldsForIncrementalCompilation
Done.

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:269: bool onlyForRti =
_task.typeTestRegistry.rtiNeededClasses.contains(element);
On 2015/01/28 07:22:37, ahe wrote:
> For incremental compilation, this should probably always be false.

Done.

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:276: Holder holder =
_registry.registerHolder(holderName);
On 2015/01/28 07:22:37, ahe wrote:
> I'm not sure I understand what a holder is. Does this help you generate only
the
> A-Z objects that are actually used?

In the new emitter it's more complicated.
Since you don't need the holder I removed the code.

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:278:
_compiler.codegenWorld.directlyInstantiatedClasses.contains(element);
On 2015/01/28 07:22:37, ahe wrote:
> For incremental compilation, my guess is that it would be better if this was
> always true.

Done.

https://codereview.chromium.org/871073002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:283: onlyForRti:
onlyForRti,
On 2015/01/28 07:22:37, ahe wrote:
> As mentioned above, the above two arguments should probably always have a
fixed
> value. This is because they are computed based on information that varies
based
> on how the program changes. Generally, those things are candidates for things
> that should be avoided during incremental compilation.

Done.

https://codereview.chromium.org/871073002/diff/1/pkg/dart2js_incremental/lib/...
File pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/871073002/diff/1/pkg/dart2js_incremental/lib/...
pkg/dart2js_incremental/lib/library_updater.dart:70: Class;
On 2015/01/28 07:22:37, ahe wrote:
> Add newline between imports.

Done.