Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 870353004: cps-ir: Implement string concatenation. (Closed)

Created:
5 years, 10 months ago by karlklose
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org, asgerf
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cps-ir: Implement string concatenation. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=43549

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use reduce. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -6 lines) Patch
M pkg/compiler/lib/src/js/builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 1 chunk +21 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_basic_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
karlklose
5 years, 10 months ago (2015-02-03 14:20:07 UTC) #1
karlklose
Ping/
5 years, 10 months ago (2015-02-06 08:34:20 UTC) #2
asgerf
DBC https://codereview.chromium.org/870353004/diff/1/pkg/compiler/lib/src/js_backend/codegen/codegen.dart File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right): https://codereview.chromium.org/870353004/diff/1/pkg/compiler/lib/src/js_backend/codegen/codegen.dart#newcode158 pkg/compiler/lib/src/js_backend/codegen/codegen.dart:158: return parts.skip(1).fold(parts.first, addStrings); Could be: parts.reduce(addStrings)
5 years, 10 months ago (2015-02-06 10:37:25 UTC) #4
Kevin Millikin (Google)
lgtm
5 years, 10 months ago (2015-02-06 10:48:14 UTC) #5
karlklose
5 years, 10 months ago (2015-02-06 11:36:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43549 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698