Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

Issue 870353004: cps-ir: Implement string concatenation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use reduce. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
index a688778f5acd77348debd3fe63ae24ee0637b72a..038ecf16120824c81aacf5644c2f79038439cf0b 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
@@ -181,6 +181,8 @@ class InvokeConstructor extends Expression implements Invoke {
final FunctionElement target;
final List<Expression> arguments;
final Selector selector;
+ /// TODO(karlklose): get rid of this field. Instead use the constant's
+ /// expression to find the constructor to be called in dart2dart.
final values.ConstantValue constant;
InvokeConstructor(this.type, this.target, this.selector, this.arguments,
@@ -197,9 +199,8 @@ class InvokeConstructor extends Expression implements Invoke {
/// Calls [toString] on each argument and concatenates the results.
class ConcatenateStrings extends Expression {
final List<Expression> arguments;
- final values.ConstantValue constant;
- ConcatenateStrings(this.arguments, [this.constant]);
+ ConcatenateStrings(this.arguments);
accept(ExpressionVisitor visitor) => visitor.visitConcatenateStrings(this);
accept1(ExpressionVisitor1 visitor, arg) {
« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/glue.dart ('k') | tests/compiler/dart2js/js_backend_cps_ir_basic_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698