Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 869543004: dart2js: store fields in the model and make the emitters use it. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: store fields in the model and make the emitters use it. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43098

Patch Set 1 #

Patch Set 2 : Remove assert that I'm not sure. #

Patch Set 3 : Rebase #

Total comments: 5

Patch Set 4 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -269 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 8 chunks +33 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 2 3 3 chunks +7 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 4 chunks +9 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 2 3 6 chunks +124 lines, -176 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 2 7 chunks +57 lines, -58 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
floitsch
5 years, 11 months ago (2015-01-22 15:15:22 UTC) #2
floitsch
https://codereview.chromium.org/869543004/diff/40001/pkg/compiler/lib/src/js_emitter/program_builder.dart File pkg/compiler/lib/src/js_emitter/program_builder.dart (left): https://codereview.chromium.org/869543004/diff/40001/pkg/compiler/lib/src/js_emitter/program_builder.dart#oldcode373 pkg/compiler/lib/src/js_emitter/program_builder.dart:373: bool _fieldNeedsGetter(VariableElement field) { These predicates were copied from ...
5 years, 11 months ago (2015-01-22 15:57:39 UTC) #3
zarah
LGTM https://codereview.chromium.org/869543004/diff/40001/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart (right): https://codereview.chromium.org/869543004/diff/40001/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart#newcode19 pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart:19: final onlyForRti = cls.onlyForRti; Inline in the assert? ...
5 years, 11 months ago (2015-01-23 10:47:31 UTC) #4
floitsch
https://codereview.chromium.org/869543004/diff/40001/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart (right): https://codereview.chromium.org/869543004/diff/40001/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart#newcode19 pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart:19: final onlyForRti = cls.onlyForRti; On 2015/01/23 10:47:30, zarah wrote: ...
5 years, 11 months ago (2015-01-23 12:27:31 UTC) #5
floitsch
5 years, 11 months ago (2015-01-23 12:27:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 43098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698