Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: pkg/compiler/lib/src/js_emitter/native_emitter.dart

Issue 869543004: dart2js: store fields in the model and make the emitters use it. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/native_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/native_emitter.dart b/pkg/compiler/lib/src/js_emitter/native_emitter.dart
index 843fd8750e14524cceab1f72a82b54d95b1b73f6..8ade755bbda687f6893d173c39b9617583ccb96f 100644
--- a/pkg/compiler/lib/src/js_emitter/native_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/native_emitter.dart
@@ -239,6 +239,7 @@ class NativeEmitter {
// Emit the native class interceptors that were actually used.
for (Class cls in classes) {
+ assert(!cls.onlyForRti);
ClassElement classElement = cls.element;
if (!cls.isNative) continue;
if (neededClasses.contains(cls)) {
@@ -249,19 +250,18 @@ class NativeEmitter {
// reason, it is important that we don't call these methods before we
// are certain that a class is needed.
- emitterTask.oldEmitter.classEmitter
- .emitConstructorsForCSP(classElement);
+ emitterTask.oldEmitter.classEmitter.emitConstructorsForCSP(cls);
// [emitClassGettersSettersForCSP] does not affect whether or not a
// class is needed. If getters/setters are emitted, the class has fields
// and is therefore non-trivial.
emitterTask.oldEmitter.classEmitter.emitClassGettersSettersForCSP(
- classElement, builder);
+ cls, builder);
// Define interceptor class for [classElement].
emitterTask.oldEmitter.classEmitter.emitClassBuilderWithReflectionData(
- cls.name,
- classElement, builders[cls],
+ cls,
+ builders[cls],
emitterTask.oldEmitter.getElementDescriptor(classElement));
emitterTask.oldEmitter.needsClassSupport = true;
}
@@ -322,10 +322,9 @@ class NativeEmitter {
builder.superName = superclass.name;
bool hasFields = emitterTask.oldEmitter.classEmitter.emitFields(
- classElement, builder, classIsNative: true);
+ cls, builder, classIsNative: true);
int propertyCount = builder.properties.length;
- emitterTask.oldEmitter.classEmitter.emitCheckedClassSetters(
- classElement, builder);
+ emitterTask.oldEmitter.classEmitter.emitCheckedClassSetters(cls, builder);
emitterTask.oldEmitter.classEmitter.emitInstanceMembers(
classElement, builder);
emitterTask.oldEmitter.classEmitter
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/model.dart ('k') | pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698