Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 869533003: VM: Emit compacter code for x64 branches to external labels. (Closed)

Created:
5 years, 11 months ago by Florian Schneider
Modified:
5 years, 11 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Emit compacter code for x64 branches to external labels. Use jmp [PP + 0xiiii] instead of movq TMP, [PP + 0xiiii] jmp TMP Also, remove some unused code from x64 assembler. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=43094

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -63 lines) Patch
M runtime/vm/assembler_x64.h View 2 chunks +1 line, -1 line 0 comments Download
M runtime/vm/assembler_x64.cc View 3 chunks +17 lines, -5 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/vm/instructions_x64.h View 2 chunks +1 line, -24 lines 0 comments Download
M runtime/vm/instructions_x64.cc View 2 chunks +2 lines, -25 lines 0 comments Download
M runtime/vm/instructions_x64_test.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 11 months ago (2015-01-22 15:05:29 UTC) #2
zra
lgtm https://codereview.chromium.org/869533003/diff/1/runtime/vm/assembler_x64.h File runtime/vm/assembler_x64.h (right): https://codereview.chromium.org/869533003/diff/1/runtime/vm/assembler_x64.h#newcode671 runtime/vm/assembler_x64.h:671: void jmp(const Address& address); Please add an assembler ...
5 years, 11 months ago (2015-01-22 16:01:56 UTC) #3
Florian Schneider
https://codereview.chromium.org/869533003/diff/1/runtime/vm/assembler_x64.h File runtime/vm/assembler_x64.h (right): https://codereview.chromium.org/869533003/diff/1/runtime/vm/assembler_x64.h#newcode671 runtime/vm/assembler_x64.h:671: void jmp(const Address& address); On 2015/01/22 16:01:56, zra wrote: ...
5 years, 11 months ago (2015-01-23 10:27:54 UTC) #4
Florian Schneider
5 years, 11 months ago (2015-01-23 10:28:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as r43094.

Powered by Google App Engine
This is Rietveld 408576698