Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: runtime/vm/instructions_x64.cc

Issue 869533003: VM: Emit compacter code for x64 branches to external labels. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_x64.h ('k') | runtime/vm/instructions_x64_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_x64.cc
===================================================================
--- runtime/vm/instructions_x64.cc (revision 43070)
+++ runtime/vm/instructions_x64.cc (working copy)
@@ -37,28 +37,6 @@
}
-uword CallPattern::TargetAddress() const {
- ASSERT(IsValid());
- return *reinterpret_cast<uword*>(start() + 2);
-}
-
-
-void CallPattern::SetTargetAddress(uword target) const {
- ASSERT(IsValid());
- *reinterpret_cast<uword*>(start() + 2) = target;
- CPU::FlushICache(start() + 2, kWordSize);
-}
-
-
-const int* CallPattern::pattern() const {
- // movq $target, TMP
- // callq *TMP
- static const int kCallPattern[kLengthInBytes] =
- {0x49, 0xBB, -1, -1, -1, -1, -1, -1, -1, -1, 0x41, 0xFF, 0xD3};
- return kCallPattern;
-}
-
-
uword JumpPattern::TargetAddress() const {
ASSERT(IsValid());
int index = InstructionPattern::IndexFromPPLoad(start() + 3);
@@ -76,10 +54,9 @@
const int* JumpPattern::pattern() const {
- // 00: 4d 8b 9d imm32 mov R11, [R13 + off]
- // 07: 41 ff e3 jmpq R11
+ // 07: 41 ff a7 imm32 jmpq [reg + off]
static const int kJumpPattern[kLengthInBytes] =
- {0x4D, 0x8B, -1, -1, -1, -1, -1, 0x41, 0xFF, 0xE3};
+ {0x41, 0xFF, -1, -1, -1, -1, -1};
return kJumpPattern;
}
« no previous file with comments | « runtime/vm/instructions_x64.h ('k') | runtime/vm/instructions_x64_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698